diff options
| author | Pedro Alves <palves@redhat.com> | 2013-07-04 16:08:22 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-07-04 16:08:22 +0000 |
| commit | 58722cac5aa9ea0b18a8fe5e76031f62cea017bc (patch) | |
| tree | 57613c08aa66afd137cc72da3c52b1e1b98c4317 | |
| parent | 691a26f5ddd5f061ae8cd1be7c68212041da6ac2 (diff) | |
| download | gdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.zip gdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.tar.gz gdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.tar.bz2 | |
value_bits_valid: Fix latent bug.
Doing something else, I factored out the bits of the value_bits_valid
function that actually handle the check_validity hook, and
surprisingly found out that the result was misbehaving. Turns out
value_bits_valid has a latent bug. If the value is not lval_computed,
or doesn't have a check_validity hook, then we should assume the value
is entirely valid, not invalid. This is currently masked by the
value->optimized_out check -- I ran the testsuite with a gdb_assert(0)
inserted in place of that return being touched by the patch, and it
never triggers.
Tested on x86_64 Fedora 17.
gdb/
2013-07-04 Pedro Alves <palves@redhat.com>
* value.c (value_bits_valid): If the value is not lval_computed,
or doesn't have a check_validity hook, assume the value is entirely
valid.
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/value.c | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 77db200..2353e71 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2013-07-04 Pedro Alves <palves@redhat.com> + + * value.c (value_bits_valid): If the value is not lval_computed, + or doesn't have a check_validity hook, assume the value is entirely + valid. + 2013-07-04 Andrew Burgess <aburgess@broadcom.com> * stack.c (read_frame_arg): No longer fetch lazy values. diff --git a/gdb/value.c b/gdb/value.c index ce4b13a..353f62a 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1086,7 +1086,7 @@ value_bits_valid (const struct value *value, int offset, int length) return 1; if (value->lval != lval_computed || !value->location.computed.funcs->check_validity) - return 0; + return 1; return value->location.computed.funcs->check_validity (value, offset, length); } |