diff options
| author | Pedro Alves <palves@redhat.com> | 2013-08-30 15:37:37 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-08-30 15:37:37 +0000 |
| commit | 02457c768f78754f76d81b241236338ee2e28a86 (patch) | |
| tree | b3e327bfaafa6a149c5ad1999a315ec30f04fe67 | |
| parent | e0162910f16c309b8bc642cfb1558babe92993f7 (diff) | |
| download | gdb-02457c768f78754f76d81b241236338ee2e28a86.zip gdb-02457c768f78754f76d81b241236338ee2e28a86.tar.gz gdb-02457c768f78754f76d81b241236338ee2e28a86.tar.bz2 | |
MI -trace-find, print frame with LOC_AND_ADDRESS instead of SRC_AND_LOC.
When I looked for print_stack_frame calls in MI, I wondered why this
one passing down SRC_AND_LOC. print_stack_frame does:
/* For mi, alway print location and address. */
if (ui_out_is_mi_like_p (current_uiout))
print_what = LOC_AND_ADDRESS;
So it really doesn't matter which value is passed down, but, to avoid
confusion in readers, it's better to use the MI standard here.
There's another SRC_AND_LOC in mi-interp.c, but that one makes sense.
gdb/
2013-08-30 Pedro Alves <palves@redhat.com>
* mi/mi-main.c (mi_cmd_trace_find): Use LOC_AND_ADDRESS instead of
SRC_AND_LOC.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/mi/mi-main.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 18ecb44..6b074b8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2013-08-30 Pedro Alves <palves@redhat.com> + * mi/mi-main.c (mi_cmd_trace_find): Use LOC_AND_ADDRESS instead of + SRC_AND_LOC. + +2013-08-30 Pedro Alves <palves@redhat.com> + * thread.c (restore_selected_frame): Use SRC_AND_LOC, and change warning text. diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 64a8ae3..e6e98b6 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -2484,7 +2484,7 @@ mi_cmd_trace_find (char *command, char **argv, int argc) error (_("Invalid mode '%s'"), mode); if (has_stack_frames () || get_traceframe_number () >= 0) - print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC); + print_stack_frame (get_selected_frame (NULL), 1, LOC_AND_ADDRESS); } void |