aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2016-05-02 13:10:33 -0400
committerSimon Marchi <simon.marchi@ericsson.com>2016-05-02 13:10:33 -0400
commit444e826c911693e6dad1cf907d81eb9dc1bef7d2 (patch)
treed6d21389bf3ef8a24a98d6a87f59b07fa95df373
parent740feeaa2049d0f9a7e5928191124583a1a8c645 (diff)
downloadgdb-444e826c911693e6dad1cf907d81eb9dc1bef7d2.zip
gdb-444e826c911693e6dad1cf907d81eb9dc1bef7d2.tar.gz
gdb-444e826c911693e6dad1cf907d81eb9dc1bef7d2.tar.bz2
Fix detach.exp remote check
This test seems to work with both native-gdbserver and native-extended-gdbserver, so I removed the remote check. When running with native-gdbserver (a stub-like target), detach makes gdbserver stop and gdb disconnect. runto_main just spawns a brand new gdbserver. So it tests the exact same thing twice. It doesn't hurt though. With native-extended-gdbserver, the test is probably a bit more useful (and similar to native). It tests running/detaching twice using the same gdb/gdbserver instances, since with extended-remote, you can detach/attach/run all you want, unlike with remote. gdb/testsuite/ChangeLog: * gdb.base/detach.exp: Remove is_remote check.
-rw-r--r--gdb/testsuite/ChangeLog4
-rw-r--r--gdb/testsuite/gdb.base/detach.exp5
2 files changed, 4 insertions, 5 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fb6538c..6d34da6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2016-05-02 Simon Marchi <simon.marchi@ericsson.com>
+ * gdb.base/detach.exp: Remove is_remote check.
+
+2016-05-02 Simon Marchi <simon.marchi@ericsson.com>
+
* gdb.base/annota-input-while-running.exp: Don't check for
[is_remote target]. Enable annotations after running to main.
Remove unused "set test..." line.
diff --git a/gdb/testsuite/gdb.base/detach.exp b/gdb/testsuite/gdb.base/detach.exp
index 920dac2..b9343ee 100644
--- a/gdb/testsuite/gdb.base/detach.exp
+++ b/gdb/testsuite/gdb.base/detach.exp
@@ -22,11 +22,6 @@ if { ! [istarget "*-*-linux*"] } {
return 0
}
-# Are we on a target board?
-if [is_remote target] then {
- return 0
-}
-
standard_testfile attach.c
set escapedbinfile [string_to_regexp ${binfile}]