aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Kratochvil <jan.kratochvil@redhat.com>2013-04-12 16:04:07 +0000
committerJan Kratochvil <jan.kratochvil@redhat.com>2013-04-12 16:04:07 +0000
commit39ed5604d7bee498aa7cdd6a7bc9bf86df366fec (patch)
treebd92a251d8da01bd3293bf633c0d91c4b6e9ddd4
parent49369217974f88031ae5f65eba0274bc30ecf74d (diff)
downloadgdb-39ed5604d7bee498aa7cdd6a7bc9bf86df366fec.zip
gdb-39ed5604d7bee498aa7cdd6a7bc9bf86df366fec.tar.gz
gdb-39ed5604d7bee498aa7cdd6a7bc9bf86df366fec.tar.bz2
gdb/
Fix GDB regression related to PR binutils/14813. * jit.c (mem_bfd_iovec_close): Return 0 for success. * minidebug.c (lzma_close): Add return value comment. * remote.c (remote_bfd_iovec_close): Return 0 for success. * solib-spu.c (spu_bfd_iovec_close): Likewise. * spu-linux-nat.c (spu_bfd_iovec_close): Likewise.
-rw-r--r--gdb/ChangeLog11
-rw-r--r--gdb/jit.c4
-rw-r--r--gdb/minidebug.c2
-rw-r--r--gdb/remote.c3
-rw-r--r--gdb/solib-spu.c4
-rw-r--r--gdb/spu-linux-nat.c4
6 files changed, 23 insertions, 5 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dc95da1..e99bd77 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,13 @@
-2013-04-11 Jan Kratochvil <jan.kratochvil@redhat.com>
+2013-04-12 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ Fix GDB regression related to PR binutils/14813.
+ * jit.c (mem_bfd_iovec_close): Return 0 for success.
+ * minidebug.c (lzma_close): Add return value comment.
+ * remote.c (remote_bfd_iovec_close): Return 0 for success.
+ * solib-spu.c (spu_bfd_iovec_close): Likewise.
+ * spu-linux-nat.c (spu_bfd_iovec_close): Likewise.
+
+2013-04-12 Jan Kratochvil <jan.kratochvil@redhat.com>
* config.in: Regenerate.
diff --git a/gdb/jit.c b/gdb/jit.c
index 33d3d61..6fc8524 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -90,7 +90,9 @@ static int
mem_bfd_iovec_close (struct bfd *abfd, void *stream)
{
xfree (stream);
- return 1;
+
+ /* Zero means success. */
+ return 0;
}
/* For reading the file, we just need to pass through to target_read_memory and
diff --git a/gdb/minidebug.c b/gdb/minidebug.c
index 7b1463b..a33628a 100644
--- a/gdb/minidebug.c
+++ b/gdb/minidebug.c
@@ -226,6 +226,8 @@ lzma_close (struct bfd *nbfd,
lzma_index_end (lstream->index, &gdb_lzma_allocator);
xfree (lstream->data);
xfree (lstream);
+
+ /* Zero means success. */
return 0;
}
diff --git a/gdb/remote.c b/gdb/remote.c
index f0dbba6..96abc5d 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -9937,7 +9937,8 @@ remote_bfd_iovec_close (struct bfd *abfd, void *stream)
connection was already torn down. */
remote_hostio_close (fd, &remote_errno);
- return 1;
+ /* Zero means success. */
+ return 0;
}
static file_ptr
diff --git a/gdb/solib-spu.c b/gdb/solib-spu.c
index 7be5232..fc9dcda 100644
--- a/gdb/solib-spu.c
+++ b/gdb/solib-spu.c
@@ -286,7 +286,9 @@ static int
spu_bfd_iovec_close (bfd *nbfd, void *stream)
{
xfree (stream);
- return 1;
+
+ /* Zero means success. */
+ return 0;
}
static file_ptr
diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c
index ca8d92d..1fab9da 100644
--- a/gdb/spu-linux-nat.c
+++ b/gdb/spu-linux-nat.c
@@ -277,7 +277,9 @@ static int
spu_bfd_iovec_close (struct bfd *nbfd, void *stream)
{
xfree (stream);
- return 1;
+
+ /* Zero means success. */
+ return 0;
}
static file_ptr