diff options
| author | Andreas Krebbel <krebbel@linux.vnet.ibm.com> | 2017-01-05 19:53:14 +0100 |
|---|---|---|
| committer | Andreas Krebbel <krebbel@linux.vnet.ibm.com> | 2017-02-23 18:36:43 +0100 |
| commit | 844be12fa6bf90850d71c8210d0bad9b07c5f422 (patch) | |
| tree | ea7da3d4d31532deb8bfcd89d2e4f86a9d71e406 | |
| parent | c7b66f4d16a06b78bfe15df0b9e64aff5016ae42 (diff) | |
| download | gdb-844be12fa6bf90850d71c8210d0bad9b07c5f422.zip gdb-844be12fa6bf90850d71c8210d0bad9b07c5f422.tar.gz gdb-844be12fa6bf90850d71c8210d0bad9b07c5f422.tar.bz2 | |
S/390: Issue error for overflowing relocs.
Building PIE executable from non-PIC code results in broken binaries.
With this patch the problem is detected at link-time.
bfd/ChangeLog:
2017-01-07 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* elf64-s390.c (elf_s390_relocate_section): Issue error for
non-PLT relocs of shared libary symbol in exectuable.
| -rw-r--r-- | bfd/elf64-s390.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c index bbfcd2e..edc9b86 100644 --- a/bfd/elf64-s390.c +++ b/bfd/elf64-s390.c @@ -2701,6 +2701,18 @@ elf_s390_relocate_section (bfd *output_bfd, case R_390_PC32: case R_390_PC32DBL: case R_390_PC64: + if (h != NULL + && bfd_link_pie (info) + && !h->def_regular) + { + _bfd_error_handler (_("%B: `%s' non-PLT reloc for symbol defined " + "in shared library and accessed " + "from executable " + "(rebuild file with -fPIC ?)"), + input_bfd, h->root.root.string); + bfd_set_error (bfd_error_bad_value); + return FALSE; + } /* The target of these relocs are instruction operands residing in read-only sections. We cannot emit a runtime reloc for it. */ |