aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaciej W. Rozycki <macro@mips.com>2018-02-19 18:38:41 +0000
committerMaciej W. Rozycki <macro@mips.com>2018-02-19 18:38:41 +0000
commitb248d650a44fb49d59a548ad173a3e60646159da (patch)
treef0e5c0e27cbdb1a96991c3252de4d0c9fb12f71f
parent6798f8bfa617c72240036571cb12313fef353090 (diff)
downloadgdb-b248d650a44fb49d59a548ad173a3e60646159da.zip
gdb-b248d650a44fb49d59a548ad173a3e60646159da.tar.gz
gdb-b248d650a44fb49d59a548ad173a3e60646159da.tar.bz2
Revert "_bfd_mips_elf_final_link: Notify user about wrong .reginfo size"
Revert commit 58807c48a5a3 ("_bfd_mips_elf_final_link: Notify user about wrong .reginfo size") now that the size of the `.reginfo' section has been truly fixed in `_bfd_mips_elf_section_processing', meaning that the offending condition can be asserted again. bfd/ Revert 2018-01-12 Vlad Ivanov <vlad@ivanov.email> * elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when .reginfo section has wrong size.
-rw-r--r--bfd/ChangeLog8
-rw-r--r--bfd/elfxx-mips.c11
2 files changed, 9 insertions, 10 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6820732..2ef145c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,13 @@
2018-02-19 Maciej W. Rozycki <macro@mips.com>
+ Revert
+ 2018-01-12 Vlad Ivanov <vlad@ivanov.email>
+
+ * elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when
+ .reginfo section has wrong size.
+
+2018-02-19 Maciej W. Rozycki <macro@mips.com>
+
* elfxx-mips.c (_bfd_mips_elf_always_size_sections): Set
SEC_FIXED_SIZE and SEC_HAS_CONTENTS flags for `.reginfo' and
`.MIPS.abiflags' sections.
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index 1b24f66..e57d4cd 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -14412,16 +14412,7 @@ _bfd_mips_elf_final_link (bfd *abfd, struct bfd_link_info *info)
}
/* Size has been set in _bfd_mips_elf_always_size_sections. */
- if (o->size != sizeof (Elf32_External_RegInfo))
- {
- _bfd_error_handler
- (_("%pB: .reginfo section size should be %ld bytes, "
- "actual size is %" PRId64),
- abfd, (unsigned long) sizeof (Elf32_External_RegInfo),
- (int64_t) o->size);
-
- return FALSE;
- }
+ BFD_ASSERT(o->size == sizeof (Elf32_External_RegInfo));
/* Skip this section later on (I don't think this currently
matters, but someday it might). */