aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Blandy <jimb@codesourcery.com>2001-12-07 21:02:31 +0000
committerJim Blandy <jimb@codesourcery.com>2001-12-07 21:02:31 +0000
commit7a345fb3e39283ea821a1e7118ae2412bc53c742 (patch)
tree198809a25596cbdae44a8881bfe608d0dae543e4
parent0cf3e697e4236ec4baabbc7aac766580ee30d202 (diff)
downloadgdb-7a345fb3e39283ea821a1e7118ae2412bc53c742.zip
gdb-7a345fb3e39283ea821a1e7118ae2412bc53c742.tar.gz
gdb-7a345fb3e39283ea821a1e7118ae2412bc53c742.tar.bz2
* gdb.base/break.exp: (test_next_with_recursion): Don't change the
value of `timeout' for targets other than the mips*tx39-*.
-rw-r--r--gdb/testsuite/ChangeLog14
-rw-r--r--gdb/testsuite/gdb.base/break.exp14
2 files changed, 26 insertions, 2 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 2d31946..ee5be1c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2001-12-07 Jim Blandy <jimb@redhat.com>
+
+ * gdb.base/break.exp: (test_next_with_recursion): Don't change the
+ value of `timeout' for targets other than the mips*tx39-*.
+
2001-12-06 Michael Snyder <msnyder@redhat.com>
* gdb.asm/asm-source.exp: Add tests for info target, info symbol,
@@ -5,6 +10,15 @@
2001-12-04 Jim Blandy <jimb@redhat.com>
+ * gdb.base/completion.exp: Rather than completing very long
+ filenames, which can make the readline library produce output we
+ don't recognize, cd to the directory first, and then complete
+ using nice, short relative paths.
+
+ * gdb.base/completion.exp: On some systems, there is, in fact, a
+ variable named `b' in scope (from GDB's point of view). So use
+ `no_var_named_this' instead of `b'.
+
* gdb.base/completion.exp: Clarify indentation.
2001-12-03 Jim Blandy <jimb@redhat.com>
diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp
index e0781d8..7671d1e 100644
--- a/gdb/testsuite/gdb.base/break.exp
+++ b/gdb/testsuite/gdb.base/break.exp
@@ -783,9 +783,19 @@ proc test_next_with_recursion {} {
if [istarget "mips*tx39-*"] {
set timeout 60
- } else {
- set timeout 20
}
+ # We used to set timeout here for all other targets as well. This
+ # is almost certainly wrong. The proper timeout depends on the
+ # target system in use, and how we communicate with it, so there
+ # is no single value appropriate for all targets. The timeout
+ # should be established by the Dejagnu config file(s) for the
+ # board, and respected by the test suite.
+ #
+ # For example, if I'm running GDB over an SSH tunnel talking to a
+ # portmaster in California talking to an ancient 68k board running
+ # a crummy ROM monitor (a situation I can only wish were
+ # hypothetical), then I need a large timeout. But that's not the
+ # kind of knowledge that belongs in this file.
gdb_test next "\[0-9\]*\[\t \]+return \\(value\\);.*" \
"next over recursive call"