aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYao Qi <yao@codesourcery.com>2014-06-06 14:32:42 +0800
committerYao Qi <yao@codesourcery.com>2014-06-06 21:43:20 +0800
commite5e01dbf8911d62631e5f53c083477442e2f1119 (patch)
treeaa852e1070537c7274dd32b0e5df524d572434e4
parent0a770bb257845d8c701e67b16395b9c1b922f607 (diff)
downloadgdb-e5e01dbf8911d62631e5f53c083477442e2f1119.zip
gdb-e5e01dbf8911d62631e5f53c083477442e2f1119.tar.gz
gdb-e5e01dbf8911d62631e5f53c083477442e2f1119.tar.bz2
Tweak gdb.base/async.exp
I see two fails in async.exp on arm-none-eabi target: nexti&^M (gdb) 0x000001ba 14 x = 5; x = 5;^M completed.^M FAIL: gdb.base/async.exp: nexti& finish&^M Run till exit from #0 0x000001ba in foo () at /scratch/yqi/arm-none-eabi-lite/src/gdb-trunk/gdb/testsuite/gdb.base/async.c:14^M (gdb) 0x000001e6 in main () at /scratch/yqi/arm-none-eabi-lite/src/gdb-trunk/gdb/testsuite/gdb.base/async.c:32^M 32 y = foo ();^M Value returned is $1 = 8^M completed.^M FAIL: gdb.base/async.exp: finish& The corresponding test is "test_background "nexti&" "" ".*y = 3.*"", and it assumes that GDB "nexti" into the next source line. It is wrong on arm. After "nexti", it still stops at the same source line, and it fails. When gdb does "finish", if the PC is in the middle of a source line, the PC address is printed too. See stack.c:print_frame, if (opts.addressprint) if (!sal.symtab || frame_show_address (frame, sal) || print_what == LOC_AND_ADDRESS) { annotate_frame_address (); if (pc_p) ui_out_field_core_addr (uiout, "addr", gdbarch, pc); else ui_out_field_string (uiout, "addr", "<unavailable>"); annotate_frame_address_end (); ui_out_text (uiout, " in "); } frame_show_address checks whether PC is the middle of a source line. Since after "nexti", the inferior stops at the middle of a source line, when we do "finish" the PC address is displayed. In sum, GDB works well, but test case needs update. This patch is to add a statement at the same line to make sure "nexti" doesn't go to the new line, match the next instruction address in the output and match the hex address the output of "finish". gdb/testsuite: 2014-06-06 Yao Qi <yao@codesourcery.com> * gdb.base/async.c (foo): Add one statement. * gdb.base/async.exp: Get the next instruction address and match the output of "nexti" by instruction address. Match the hex address in the output of "finish".
-rw-r--r--gdb/testsuite/ChangeLog7
-rw-r--r--gdb/testsuite/gdb.base/async.c2
-rw-r--r--gdb/testsuite/gdb.base/async.exp16
3 files changed, 22 insertions, 3 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1b4d87f..5484618 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2014-06-06 Yao Qi <yao@codesourcery.com>
+
+ * gdb.base/async.c (foo): Add one statement.
+ * gdb.base/async.exp: Get the next instruction address and
+ match the output of "nexti" by instruction address. Match
+ the hex address in the output of "finish".
+
2014-06-06 Gary Benson <gbenson@redhat.com>
* gdb.base/call-signals.c: Remove preprocessor conditionals
diff --git a/gdb/testsuite/gdb.base/async.c b/gdb/testsuite/gdb.base/async.c
index 76ce8be..649e9e6 100644
--- a/gdb/testsuite/gdb.base/async.c
+++ b/gdb/testsuite/gdb.base/async.c
@@ -11,7 +11,7 @@ foo ()
int y;
volatile int x;
- x = 5; x = 5;
+ x = 5; x = 5; x = 5;
y = 3;
return x + y;
diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/async.exp
index 0f99b01..cce8b5b 100644
--- a/gdb/testsuite/gdb.base/async.exp
+++ b/gdb/testsuite/gdb.base/async.exp
@@ -75,10 +75,22 @@ test_background "step&" "" " foo \\(\\) at .*async.c.*x = 5.*" "step& #2"
test_background "stepi&" "" ".*$hex.*x = 5.*"
-test_background "nexti&" "" ".*y = 3.*"
+# Get the next instruction address.
+set next_insn_addr ""
+set test "get next insn"
+gdb_test_multiple {x/2i $pc} "$test" {
+ -re "=> $hex .* 0x(\[0-9a-f\]*) .*$gdb_prompt $" {
+ set next_insn_addr $expect_out(1,string)
+ pass "$test"
+ }
+}
+
+# We nexti into the same source line. The current PC is printed out.
+test_background "nexti&" "" ".* 0x0*$next_insn_addr.* x = 5; .*"
+# PC is in the middle of a source line, so the PC address is displayed.
test_background "finish&" \
- "Run till exit from #0 foo \\(\\) at.*async.c.*\r\n" \
+ "Run till exit from #0 $hex in foo \\(\\) at.*async.c.*\r\n" \
".*$hex in main \\(\\) at.*async.c.*y = foo \\(\\).*Value returned is.*= 8.*"
set jump_here [gdb_get_line_number "jump here"]