diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-11-18 18:08:50 +0000 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-11-28 00:28:58 +0000 |
| commit | dcdec67858b1db5a91c1947569d6085310bfabe6 (patch) | |
| tree | c63de3cb17599a8eb0d8dd37bce140155ad93db4 | |
| parent | 0ac2b354ee006d94d6fc46bea08f39f99b18f869 (diff) | |
| download | gdb-dcdec67858b1db5a91c1947569d6085310bfabe6.zip gdb-dcdec67858b1db5a91c1947569d6085310bfabe6.tar.gz gdb-dcdec67858b1db5a91c1947569d6085310bfabe6.tar.bz2 | |
gdb/testsuite: Fix minor bug in skip_btrace*tests procs
The two guard functions skip_btrace_tests and skip_btrace_pt_tests
have a minor bug, if the check function fails to compile then surely
we should skip the btrace tests - currently we return 0 to indicate
don't skip.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
compile.
(skip_btrace_pt_tests): Likewise.
Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
| -rw-r--r-- | gdb/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 86f2130..6b520e1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-11-28 Andrew Burgess <andrew.burgess@embecosm.com> + + * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to + compile. + (skip_btrace_pt_tests): Likewise. + 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.fortran/info-modules.exp: Compile source files in correct diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 828c91d..4682f5d 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2942,7 +2942,7 @@ gdb_caching_proc skip_btrace_tests { # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb. @@ -2993,7 +2993,7 @@ gdb_caching_proc skip_btrace_pt_tests { # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb. |