aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2016-10-12 09:41:33 +1030
committerAlan Modra <amodra@gmail.com>2016-10-12 09:41:33 +1030
commit821e6ff6299aa39e841ca50e1ae8a98e3554fd5f (patch)
tree2a15932e6386a5bc5554e4f5bfe7cffd16c062f7
parent56fdab47732aa0e051d3442fdedbe602ce367cf9 (diff)
downloadgdb-821e6ff6299aa39e841ca50e1ae8a98e3554fd5f.zip
gdb-821e6ff6299aa39e841ca50e1ae8a98e3554fd5f.tar.gz
gdb-821e6ff6299aa39e841ca50e1ae8a98e3554fd5f.tar.bz2
BFD_FAKE_SECTION macro params
Order NAME, IDX, FLAGS as per STD_SECTION macro. * section.c (BFD_FAKE_SECTION): Reorder parameters. Formatting. (STD_SECTION): Adjust to suit. * elf.c (_bfd_elf_large_com_section): Likewise. * bfd-in2.h: Regenerate.
-rw-r--r--bfd/bfd-in2.h4
-rw-r--r--bfd/elf.c8
-rw-r--r--bfd/section.c6
3 files changed, 10 insertions, 8 deletions
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 31b9584..3c0ff9d 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -1794,9 +1794,9 @@ extern asection _bfd_std_section[4];
#define bfd_section_removed_from_list(ABFD, S) \
((S)->next == NULL ? (ABFD)->section_last != (S) : (S)->next->prev != (S))
-#define BFD_FAKE_SECTION(SEC, FLAGS, SYM, NAME, IDX) \
+#define BFD_FAKE_SECTION(SEC, SYM, NAME, IDX, FLAGS) \
/* name, id, index, next, prev, flags, user_set_vma, */ \
- { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
+ { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
\
/* linker_mark, linker_has_input, gc_mark, decompress_status, */ \
0, 0, 1, 0, \
diff --git a/bfd/elf.c b/bfd/elf.c
index c096191..a85498d 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -11034,10 +11034,12 @@ _bfd_elf_get_synthetic_symtab (bfd *abfd,
return n;
}
-/* It is only used by x86-64 so far. */
+/* It is only used by x86-64 so far.
+ ??? This repeats *COM* id of zero. sec->id is supposed to be unique,
+ but current usage would allow all of _bfd_std_section to be zero. t*/
asection _bfd_elf_large_com_section
- = BFD_FAKE_SECTION (_bfd_elf_large_com_section,
- SEC_IS_COMMON, NULL, "LARGE_COMMON", 0);
+ = BFD_FAKE_SECTION (_bfd_elf_large_com_section, NULL,
+ "LARGE_COMMON", 0, SEC_IS_COMMON);
void
_bfd_elf_post_process_headers (bfd * abfd,
diff --git a/bfd/section.c b/bfd/section.c
index 70cb267..8df9891 100644
--- a/bfd/section.c
+++ b/bfd/section.c
@@ -700,9 +700,9 @@ CODE_FRAGMENT
.#define bfd_section_removed_from_list(ABFD, S) \
. ((S)->next == NULL ? (ABFD)->section_last != (S) : (S)->next->prev != (S))
.
-.#define BFD_FAKE_SECTION(SEC, FLAGS, SYM, NAME, IDX) \
+.#define BFD_FAKE_SECTION(SEC, SYM, NAME, IDX, FLAGS) \
. {* name, id, index, next, prev, flags, user_set_vma, *} \
-. { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
+. { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
. \
. {* linker_mark, linker_has_input, gc_mark, decompress_status, *} \
. 0, 0, 1, 0, \
@@ -764,7 +764,7 @@ static const asymbol global_syms[] =
};
#define STD_SECTION(NAME, IDX, FLAGS) \
- BFD_FAKE_SECTION(_bfd_std_section[IDX], FLAGS, &global_syms[IDX], NAME, IDX)
+ BFD_FAKE_SECTION(_bfd_std_section[IDX], &global_syms[IDX], NAME, IDX, FLAGS)
asection _bfd_std_section[] = {
STD_SECTION (BFD_COM_SECTION_NAME, 0, SEC_IS_COMMON),