aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2024-08-22 09:49:53 +0200
committerTom de Vries <tdevries@suse.de>2024-08-22 09:49:53 +0200
commit50f8a39878d6c8cf4dfcb1d3333aa2a20daada0c (patch)
tree8c550a230e5c2ec5271e51c2517faca595f59497
parent365b32b9c7792cb5fb67c658ea28b1c3a7a8ef71 (diff)
downloadgdb-50f8a39878d6c8cf4dfcb1d3333aa2a20daada0c.zip
gdb-50f8a39878d6c8cf4dfcb1d3333aa2a20daada0c.tar.gz
gdb-50f8a39878d6c8cf4dfcb1d3333aa2a20daada0c.tar.bz2
[gdb] Add const to catch gdb_exception
I did a review of lines containing "catch (gdb_exception" and found a few where we can add const. Tested on x86_64-linux. Approved-By: Tom Tromey <tom@tromey.com>
-rw-r--r--gdb/exec.c2
-rw-r--r--gdb/python/py-breakpoint.c4
-rw-r--r--gdb/python/py-inferior.c4
-rw-r--r--gdb/python/py-value.c4
-rw-r--r--gdb/unittests/scoped_mmap-selftests.c2
5 files changed, 8 insertions, 8 deletions
diff --git a/gdb/exec.c b/gdb/exec.c
index 63eee42..683b0a1 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -294,7 +294,7 @@ validate_exec_file (int from_tty)
symbol_file_add_main (exec_file_target.c_str (), add_flags);
exec_file_attach (exec_file_target.c_str (), from_tty);
}
- catch (gdb_exception_error &err)
+ catch (const gdb_exception_error &err)
{
warning (_("loading %ps %s"),
styled_string (file_name_style.style (),
diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c
index e7dd470..7401397 100644
--- a/gdb/python/py-breakpoint.c
+++ b/gdb/python/py-breakpoint.c
@@ -611,7 +611,7 @@ bppy_set_condition (PyObject *self, PyObject *newvalue, void *closure)
{
set_breakpoint_condition (self_bp->bp, exp, 0, false);
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
GDB_PY_SET_HANDLE_EXCEPTION (ex);
}
@@ -677,7 +677,7 @@ bppy_set_commands (PyObject *self, PyObject *newvalue, void *closure)
counted_command_line lines = read_command_lines_1 (reader, 1, nullptr);
breakpoint_set_commands (self_bp->bp, std::move (lines));
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
GDB_PY_SET_HANDLE_EXCEPTION (ex);
}
diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c
index a1042ee..ccc3e88 100644
--- a/gdb/python/py-inferior.c
+++ b/gdb/python/py-inferior.c
@@ -631,7 +631,7 @@ infpy_write_memory (PyObject *self, PyObject *args, PyObject *kw)
write_memory_with_notification (addr, buffer, length);
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
GDB_PY_HANDLE_EXCEPTION (ex);
}
@@ -705,7 +705,7 @@ infpy_search_memory (PyObject *self, PyObject *args, PyObject *kw)
buffer, pattern_size,
&found_addr);
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
GDB_PY_HANDLE_EXCEPTION (ex);
}
diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c
index 5c62ef6..4980076 100644
--- a/gdb/python/py-value.c
+++ b/gdb/python/py-value.c
@@ -1178,7 +1178,7 @@ valpy_getitem (PyObject *self, PyObject *key)
if (res_val)
result = value_to_value_object (res_val);
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
GDB_PY_HANDLE_EXCEPTION (ex);
}
@@ -1704,7 +1704,7 @@ valpy_nonzero (PyObject *self)
/* All other values are True. */
nonzero = 1;
}
- catch (gdb_exception &ex)
+ catch (const gdb_exception &ex)
{
/* This is not documented in the Python documentation, but if
this function fails, return -1 as slot_nb_nonzero does (the
diff --git a/gdb/unittests/scoped_mmap-selftests.c b/gdb/unittests/scoped_mmap-selftests.c
index 7b3a6f5..09a94ed 100644
--- a/gdb/unittests/scoped_mmap-selftests.c
+++ b/gdb/unittests/scoped_mmap-selftests.c
@@ -114,7 +114,7 @@ test_invalid_filename ()
try {
::scoped_mmap m = ::mmap_file ("/this/file/should/not/exist");
- } catch (gdb_exception &e) {
+ } catch (const gdb_exception &e) {
threw = true;
}