aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2022-02-22 12:02:10 -0700
committerTom Tromey <tromey@adacore.com>2022-04-04 12:46:08 -0600
commit45016746f1a992e7300cae74761c681a8a3f4fe7 (patch)
treea609743440e8e2a6494e03d7db223853ba16eaad
parentc3f2a3738a3603f51e3621504d8207767526add9 (diff)
downloadgdb-45016746f1a992e7300cae74761c681a8a3f4fe7.zip
gdb-45016746f1a992e7300cae74761c681a8a3f4fe7.tar.gz
gdb-45016746f1a992e7300cae74761c681a8a3f4fe7.tar.bz2
Fix bug in Ada attributes lexing
The Ada lexer allows whitespace between the apostrophe and the attribute text, but processAttribute does not handle this. This patch fixes the problem and introduces a regression test.
-rw-r--r--gdb/ada-lex.l7
-rw-r--r--gdb/testsuite/gdb.ada/formatted_ref.exp16
2 files changed, 15 insertions, 8 deletions
diff --git a/gdb/ada-lex.l b/gdb/ada-lex.l
index a0c9816..c6ce1ae 100644
--- a/gdb/ada-lex.l
+++ b/gdb/ada-lex.l
@@ -227,7 +227,7 @@ false { return FALSEKEYWORD; }
/* ATTRIBUTES */
-{TICK}[a-z][a-z_]+ { BEGIN INITIAL; return processAttribute (yytext+1); }
+{TICK}[a-z][a-z_]+ { BEGIN INITIAL; return processAttribute (yytext); }
/* PUNCTUATION */
@@ -663,6 +663,11 @@ attributes[] = {
static int
processAttribute (const char *str)
{
+ gdb_assert (*str == '\'');
+ ++str;
+ while (isspace (*str))
+ ++str;
+
for (const auto &item : attributes)
if (strcasecmp (str, item.name) == 0)
return item.code;
diff --git a/gdb/testsuite/gdb.ada/formatted_ref.exp b/gdb/testsuite/gdb.ada/formatted_ref.exp
index bb5f78c..882dbf1 100644
--- a/gdb/testsuite/gdb.ada/formatted_ref.exp
+++ b/gdb/testsuite/gdb.ada/formatted_ref.exp
@@ -70,13 +70,15 @@ proc test_p_x_addr { var addr } {
global gdb_prompt
foreach attr {access unchecked_access unrestricted_access} {
- set test "print/x $var'$attr"
- gdb_test_multiple $test $test {
- -re "\\$\[0-9\]+ = $addr.*$gdb_prompt $" {
- pass $test
- }
- -re "\\$\[0-9\]+ = 0x\[a-f0-9+\]+.*$gdb_prompt $" {
- fail "$test (prints unexpected address)"
+ foreach space {"" " "} {
+ set test "print/x $var'$space$attr"
+ gdb_test_multiple $test $test {
+ -re "\\$\[0-9\]+ = $addr.*$gdb_prompt $" {
+ pass $test
+ }
+ -re "\\$\[0-9\]+ = 0x\[a-f0-9+\]+.*$gdb_prompt $" {
+ fail "$test (prints unexpected address)"
+ }
}
}
}