diff options
author | Tom de Vries <tdevries@suse.de> | 2021-10-13 11:06:36 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2021-10-13 11:06:36 +0200 |
commit | 36170420e329a8d6229eb89b38d8680cf39f1d53 (patch) | |
tree | 347bd307d99d456054c72aa4759434c64e868275 | |
parent | 746723ba6c1b36d6ec88de3f772a80a8d2de6e4d (diff) | |
download | gdb-36170420e329a8d6229eb89b38d8680cf39f1d53.zip gdb-36170420e329a8d6229eb89b38d8680cf39f1d53.tar.gz gdb-36170420e329a8d6229eb89b38d8680cf39f1d53.tar.bz2 |
[gdb/testsuite] Fix test name in gdb.python/python.exp
When running test-case gdb.python/python.exp, we have:
...
PASS: gdb.python/python.exp: starti via gdb.execute, not from tty
PASS: gdb.python/python.exp: starti via interactive input
...
The two tests are instances of the same test, with different values for
starti command argument from_tty, so it's strange that the test names are so
different.
This is due to using a gdb_test nested in a gdb_test_multiple, with the inner
one using a different test name than the outer one. [ That could still make
sense if both produced passes, but that's not the case here. ]
Fix this by using $gdb_test_name, such that we have:
...
PASS: gdb.python/python.exp: starti via gdb.execute, not from tty
PASS: gdb.python/python.exp: starti via gdb.execute, from tty
...
Also make this more readable by using variables.
Tested on x86_64-linux.
-rw-r--r-- | gdb/testsuite/gdb.python/python.exp | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/gdb/testsuite/gdb.python/python.exp b/gdb/testsuite/gdb.python/python.exp index a81cd5c..7f9c2b4 100644 --- a/gdb/testsuite/gdb.python/python.exp +++ b/gdb/testsuite/gdb.python/python.exp @@ -542,12 +542,19 @@ gdb_test "python gdb.execute(\"show commands\")" "$decimal print \\\$cvar3.*" # Test that the from_tty argument to gdb.execute is effective. If # False, the user is not prompted for decisions such as restarting the # program, and "yes" is assumed. If True, the user is prompted. +# Case 1, from_tty=False. gdb_test "python gdb.execute('starti', from_tty=False)" \ "Program stopped.*" \ "starti via gdb.execute, not from tty" -gdb_test_multiple "python gdb.execute('starti', from_tty=True)" \ - "starti via gdb.execute, from tty" { - -re {The program being debugged has been started already\.\r\nStart it from the beginning\? \(y or n\) $} { - gdb_test "y" "Starting program:.*" "starti via interactive input" + +# Case 2, from_tty=True. +set test "starti via gdb.execute, from tty" +set question \ + [multi_line \ + {The program being debugged has been started already\.} \ + {Start it from the beginning\? \(y or n\) $}] +gdb_test_multiple "python gdb.execute('starti', from_tty=True)" $test { + -re $question { + gdb_test "y" "Starting program:.*" $gdb_test_name } } |