diff options
| author | Tom Tromey <tom@tromey.com> | 2020-09-28 19:38:25 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2020-09-28 19:52:21 -0600 |
| commit | 05374cfd90b59c62f9230baa19e71a3d9ed27269 (patch) | |
| tree | 059e038abb0a1568752db28073eb6ed64ce78177 | |
| parent | 9dccd06e8a4e55adb58d8ebe7f2ed7d9d7dc17de (diff) | |
| download | gdb-05374cfd90b59c62f9230baa19e71a3d9ed27269.zip gdb-05374cfd90b59c62f9230baa19e71a3d9ed27269.tar.gz gdb-05374cfd90b59c62f9230baa19e71a3d9ed27269.tar.bz2 | |
Turn target_can_execute_reverse into function
This changes target_can_execute_reverse from an object-like macro to
an inline function.
gdb/ChangeLog
2020-09-28 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (exec_reverse_continue)
(mi_cmd_list_target_features): Update.
* infrun.c (set_exec_direction_func): Update.
* target.c (default_execution_direction): Update.
* reverse.c (exec_reverse_once): Update.
* target.h (target_can_execute_reverse): Now a function.
| -rw-r--r-- | gdb/ChangeLog | 9 | ||||
| -rw-r--r-- | gdb/infrun.c | 2 | ||||
| -rw-r--r-- | gdb/mi/mi-main.c | 4 | ||||
| -rw-r--r-- | gdb/reverse.c | 2 | ||||
| -rw-r--r-- | gdb/target.c | 2 | ||||
| -rw-r--r-- | gdb/target.h | 7 |
6 files changed, 19 insertions, 7 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dbd1e1e..dcce821 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,14 @@ 2020-09-28 Tom Tromey <tom@tromey.com> + * mi/mi-main.c (exec_reverse_continue) + (mi_cmd_list_target_features): Update. + * infrun.c (set_exec_direction_func): Update. + * target.c (default_execution_direction): Update. + * reverse.c (exec_reverse_once): Update. + * target.h (target_can_execute_reverse): Now a function. + +2020-09-28 Tom Tromey <tom@tromey.com> + * tui/tui-regs.c (tui_get_register) (tui_data_window::show_registers): Update. * thread.c (scoped_restore_current_thread::restore) diff --git a/gdb/infrun.c b/gdb/infrun.c index 118538d..e4bd692 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -9145,7 +9145,7 @@ static void set_exec_direction_func (const char *args, int from_tty, struct cmd_list_element *cmd) { - if (target_can_execute_reverse) + if (target_can_execute_reverse ()) { if (!strcmp (exec_direction, exec_forward)) execution_direction = EXEC_FORWARD; diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 99da554..c5c7be7 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -321,7 +321,7 @@ exec_reverse_continue (char **argv, int argc) if (dir == EXEC_REVERSE) error (_("Already in reverse mode.")); - if (!target_can_execute_reverse) + if (!target_can_execute_reverse ()) error (_("Target %s does not support this command."), target_shortname); scoped_restore save_exec_dir = make_scoped_restore (&execution_direction, @@ -1684,7 +1684,7 @@ mi_cmd_list_target_features (const char *command, char **argv, int argc) ui_out_emit_list list_emitter (uiout, "features"); if (mi_async_p ()) uiout->field_string (NULL, "async"); - if (target_can_execute_reverse) + if (target_can_execute_reverse ()) uiout->field_string (NULL, "reverse"); return; } diff --git a/gdb/reverse.c b/gdb/reverse.c index 583e0d0..4aa2225 100644 --- a/gdb/reverse.c +++ b/gdb/reverse.c @@ -44,7 +44,7 @@ exec_reverse_once (const char *cmd, const char *args, int from_tty) error (_("Already in reverse mode. Use '%s' or 'set exec-dir forward'."), cmd); - if (!target_can_execute_reverse) + if (!target_can_execute_reverse ()) error (_("Target %s does not support this command."), target_shortname); std::string reverse_command = string_printf ("%s %s", cmd, args ? args : ""); diff --git a/gdb/target.c b/gdb/target.c index ea15357..4f58daa 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -525,7 +525,7 @@ default_get_ada_task_ptid (struct target_ops *self, long lwp, long tid) static enum exec_direction_kind default_execution_direction (struct target_ops *self) { - if (!target_can_execute_reverse) + if (!target_can_execute_reverse ()) return EXEC_FORWARD; else if (!target_can_async_p ()) return EXEC_FORWARD; diff --git a/gdb/target.h b/gdb/target.h index f58334a..ea777f2 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -2117,8 +2117,11 @@ extern int target_ranged_break_num_registers (void); extern int target_masked_watch_num_registers (CORE_ADDR addr, CORE_ADDR mask); /* Target can execute in reverse? */ -#define target_can_execute_reverse \ - current_top_target ()->can_execute_reverse () +static inline bool +target_can_execute_reverse () +{ + return current_top_target ()->can_execute_reverse (); +} extern const struct target_desc *target_read_description (struct target_ops *); |