diff options
| author | Sergio Durigan Junior <sergiodj@redhat.com> | 2019-02-23 10:05:19 -0500 |
|---|---|---|
| committer | Sergio Durigan Junior <sergiodj@redhat.com> | 2019-02-23 10:05:19 -0500 |
| commit | 8a6a85134d78531c6adb72a888844f7cfa3a5c56 (patch) | |
| tree | b000c708c280ff1bc296a8fb6c4a72631f65ecbe | |
| parent | e0e7d3bd218e50275b4c9c9fbf2d3123c73372a9 (diff) | |
| download | gdb-8a6a85134d78531c6adb72a888844f7cfa3a5c56.zip gdb-8a6a85134d78531c6adb72a888844f7cfa3a5c56.tar.gz gdb-8a6a85134d78531c6adb72a888844f7cfa3a5c56.tar.bz2 | |
Use '--readnever' when invoking GDB from gcore.in
Back when I proposed the '--readnever' feature, I somehow forgot or
decided not to include the bits related to gcore.in in the original
patch. This patch finally updates the gcore script to invoke GDB
using '--readnever'.
We've been carrying this patch on Fedora GDB for quite some time, and
as expected the corefiles generated by gcore on Fedora don't have
problems, which I think is the best indicator that the it's safe to
generate corefiles using '--readnever'.
gdb/ChangeLog:
2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
* gcore.in: Add '--readnever' option when invoking GDB.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/gcore.in | 3 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6a551df..9a57402 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com> + + * gcore.in: Add '--readnever' option when invoking GDB. + 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca> * MAINTAINERS: Update my email address. diff --git a/gdb/gcore.in b/gdb/gcore.in index 2560239..b9770ea 100644 --- a/gdb/gcore.in +++ b/gdb/gcore.in @@ -97,7 +97,8 @@ for pid in "$@" do # `</dev/null' to avoid touching interactive terminal if it is # available but not accessible as GDB would get stopped on SIGTTIN. - "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null --nx --batch \ + "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null \ + --nx --batch --readnever \ -ex "set pagination off" -ex "set height 0" -ex "set width 0" \ "${dump_all_cmds[@]}" \ -ex "attach $pid" -ex "gcore $prefix.$pid" -ex detach -ex quit |