diff options
| author | Pedro Alves <palves@redhat.com> | 2010-03-15 00:31:16 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2010-03-15 00:31:16 +0000 |
| commit | f52cd8cdd84ce53129ed4ab610b04d7503cd8208 (patch) | |
| tree | 22e57b0b23543e36347cf7db373c0dfe36e90028 | |
| parent | 19941bfa3793357ccbe2d0d273a2e338c70f1812 (diff) | |
| download | gdb-f52cd8cdd84ce53129ed4ab610b04d7503cd8208.zip gdb-f52cd8cdd84ce53129ed4ab610b04d7503cd8208.tar.gz gdb-f52cd8cdd84ce53129ed4ab610b04d7503cd8208.tar.bz2 | |
* linux-low.c (fetch_register): Avoid passing a non string literal
format to `error'.
(usr_store_inferior_registers): Ditto.
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-low.c | 21 |
2 files changed, 8 insertions, 19 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index b8c26fa..229ccea 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,9 @@ +2010-03-15 Pedro Alves <pedro@codesourcery.com> + + * linux-low.c (fetch_register): Avoid passing a non string literal + format to `error'. + (usr_store_inferior_registers): Ditto. + 2010-03-14 Pedro Alves <pedro@codesourcery.com> * linux-low.c (linux_write_memory): Bail out early if peeking diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 1b34484..4ccadbc 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -2217,23 +2217,13 @@ fetch_register (struct regcache *regcache, int regno) (PTRACE_ARG3_TYPE) (uintptr_t) regaddr, 0); regaddr += sizeof (PTRACE_XFER_TYPE); if (errno != 0) - { - /* Warning, not error, in case we are attached; sometimes the - kernel doesn't let us at the registers. */ - char *err = strerror (errno); - char *msg = alloca (strlen (err) + 128); - sprintf (msg, "reading register %d: %s", regno, err); - error (msg); - goto error_exit; - } + error ("reading register %d: %s", regno, strerror (errno)); } if (the_low_target.supply_ptrace_register) the_low_target.supply_ptrace_register (regcache, regno, buf); else supply_register (regcache, regno, buf); - -error_exit:; } /* Fetch all registers, or just one, from the child process. */ @@ -2299,14 +2289,7 @@ usr_store_inferior_registers (struct regcache *regcache, int regno) return; if ((*the_low_target.cannot_store_register) (regno) == 0) - { - char *err = strerror (errno); - char *msg = alloca (strlen (err) + 128); - sprintf (msg, "writing register %d: %s", - regno, err); - error (msg); - return; - } + error ("writing register %d: %s", regno, strerror (errno)); } regaddr += sizeof (PTRACE_XFER_TYPE); } |