aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPedro Alves <pedro@palves.net>2024-05-09 13:01:53 +0100
committerPedro Alves <pedro@palves.net>2024-05-10 11:48:57 +0100
commit78b2db9e7f5a04fdc030a5c65f8873a2c3d3c187 (patch)
tree68734927382d25df4636bad90738f8cccdd32e27
parent408bc9c5fc757bd4b8adb1c3d54ecd672beaedb7 (diff)
downloadgdb-78b2db9e7f5a04fdc030a5c65f8873a2c3d3c187.zip
gdb-78b2db9e7f5a04fdc030a5c65f8873a2c3d3c187.tar.gz
gdb-78b2db9e7f5a04fdc030a5c65f8873a2c3d3c187.tar.bz2
gdb sim testing, set gdb_protocol to "sim"
Bernd reported that when testing with riscv-unknown-elf target using the simulator, before commit c7a2ee649115 ("gdb_is_target_native -> gdb_protocol_is_native"), he had: PASS: gdb.base/load-command.exp: probe for target native PASS: gdb.base/load-command.exp: check initial value of the_variable PASS: gdb.base/load-command.exp: manually change the_variable PASS: gdb.base/load-command.exp: check manually changed value of the_variable PASS: gdb.base/load-command.exp: reload: re-load binary PASS: gdb.base/load-command.exp: reload: check initial value of the_variable and now: UNSUPPORTED: gdb.base/load-command.exp: the native target does not support the load command The problem is that the sim board/config isn't setting gdb_protocol anywhere, so gdb_protocol_is_native returns true. This commit fixes it by making gdb/testsuite/config/sim.exp set gdb_protocol to "sim". Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Tested-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Change-Id: I48a7afed004a3517b90220674fe5bc856fe7d09a
-rw-r--r--gdb/testsuite/config/sim.exp4
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp
index 81736d2..da2780e 100644
--- a/gdb/testsuite/config/sim.exp
+++ b/gdb/testsuite/config/sim.exp
@@ -14,6 +14,10 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# If we left this empty, the core of the testsuite would think we were
+# connecting to the native target.
+set_board_info gdb_protocol "sim"
+
#
# gdb_target_sim
# Set gdb to target the simulator