diff options
| author | Pedro Alves <palves@redhat.com> | 2016-04-12 16:49:30 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2016-04-12 16:55:16 +0100 |
| commit | 4a81fd47b3052f4c1601f8eb7f7879b12e0473cd (patch) | |
| tree | 814985bc78456d798faf70e518e4501431ebfce1 | |
| parent | abf009ef94d2f89b09767cce30bcf99224c1a0a9 (diff) | |
| download | gdb-4a81fd47b3052f4c1601f8eb7f7879b12e0473cd.zip gdb-4a81fd47b3052f4c1601f8eb7f7879b12e0473cd.tar.gz gdb-4a81fd47b3052f4c1601f8eb7f7879b12e0473cd.tar.bz2 | |
Don't call clear_quit_flag in command_handler
This just looks totally wrong to me, for completetly discarding a
user-requested Ctrl-C. I can't think of why we'd want do this here.
Actually, I digged the history, and found out that this has been here
since at least 7b4ac7e1ed2c (gdb-2.4, the initial revision, 1988), at
a time were we had a top level setjmp/longjmp, long before that got
wrapped in throw_exception and friends, and this code was in an
explicit loop, with the quit_flag cleared on every iteration, before
executing a command...
gdb/ChangeLog:
2016-04-12 Pedro Alves <palves@redhat.com>
* event-top.c (command_handler): Don't call clear_quit_flag.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/event-top.c | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f3dab72..f01183e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-04-12 Pedro Alves <palves@redhat.com> + * event-top.c (command_handler): Don't call clear_quit_flag. + +2016-04-12 Pedro Alves <palves@redhat.com> + * remote-sim.c (gdb_os_poll_quit): Don't call clear_quit_flag. * remote.c (remote_wait_as): Don't call clear_quit_flag. diff --git a/gdb/event-top.c b/gdb/event-top.c index eef1514..69087cc 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -460,7 +460,6 @@ command_handler (char *command) struct cleanup *stat_chain; char *c; - clear_quit_flag (); if (instream == stdin) reinitialize_more_filter (); |