diff options
| author | Yao Qi <yao.qi@linaro.org> | 2016-03-04 16:02:15 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2016-03-04 16:02:15 +0000 |
| commit | f1771dcebf80c75a13ca456491ddfb9b43fcaddf (patch) | |
| tree | 3ed38e990bf78b22eff4c28f2c5686d678e52130 | |
| parent | ca92db2d5885c03d3e0ed23c96b5c6ab336d908d (diff) | |
| download | gdb-f1771dcebf80c75a13ca456491ddfb9b43fcaddf.zip gdb-f1771dcebf80c75a13ca456491ddfb9b43fcaddf.tar.gz gdb-f1771dcebf80c75a13ca456491ddfb9b43fcaddf.tar.bz2 | |
ARM process record: VMOV
ARM process record gets the wrong register number for VMOV (from core
register to single-precision register). That is, we should record
the D register rather than the S pseudo register. The patch also
removes the condition "bit (arm_insn_r->arm_insn, 20)" check, which
has been checked above.
It fixes the following internal error,
(gdb) PASS: gdb.reverse/finish-precsave.exp: BP at end of main
continue^M
Continuing.^M
../../binutils-gdb/gdb/regcache.c:649: internal-error: regcache_raw_read: Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed.^M
A problem internal to GDB has been detected,FAIL: gdb.reverse/finish-precsave.exp: run to end of main (GDB internal error)
gdb:
2016-03-04 Yao Qi <yao.qi@linaro.org>
* arm-tdep.c (arm_record_vdata_transfer_insn): Simplify the
condition check. Record the right D register number.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/arm-tdep.c | 13 |
2 files changed, 7 insertions, 11 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 773a9e6..7f37014 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2016-03-04 Yao Qi <yao.qi@linaro.org> + * arm-tdep.c (arm_record_vdata_transfer_insn): Simplify the + condition check. Record the right D register number. + +2016-03-04 Yao Qi <yao.qi@linaro.org> + * arm-tdep.c (arm_record_extension_space): Remove code printing "Process record does not support". (arm_record_data_proc_misc_ld_str): Likewise. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 605f09b..54a21ef 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -10800,12 +10800,7 @@ arm_record_vdata_transfer_insn (insn_decode_record *arm_insn_r) /* Handle VMOV instruction. */ if (bits_a == 0x00) { - if (bit (arm_insn_r->arm_insn, 20)) - record_buf[0] = reg_t; - else - record_buf[0] = num_regs + (bit (arm_insn_r->arm_insn, 7) | - (reg_v << 1)); - + record_buf[0] = reg_t; arm_insn_r->reg_rec_count = 1; } /* Handle VMRS instruction. */ @@ -10823,11 +10818,7 @@ arm_record_vdata_transfer_insn (insn_decode_record *arm_insn_r) /* Handle VMOV instruction. */ if (bits_a == 0x00) { - if (bit (arm_insn_r->arm_insn, 20)) - record_buf[0] = reg_t; - else - record_buf[0] = num_regs + (bit (arm_insn_r->arm_insn, 7) | - (reg_v << 1)); + record_buf[0] = ARM_D0_REGNUM + reg_v; arm_insn_r->reg_rec_count = 1; } |