diff options
| author | Pedro Alves <palves@redhat.com> | 2015-02-04 14:53:24 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2015-02-04 14:53:24 +0100 |
| commit | 42d9e5288b6576b56f3f803901433b88ee863bc6 (patch) | |
| tree | bace26533b18a08d1e4b07d2a8ae3b73b92165e7 | |
| parent | f962539ad23759af4ba8f7eece1946fdc2f50876 (diff) | |
| download | gdb-42d9e5288b6576b56f3f803901433b88ee863bc6.zip gdb-42d9e5288b6576b56f3f803901433b88ee863bc6.tar.gz gdb-42d9e5288b6576b56f3f803901433b88ee863bc6.tar.bz2 | |
Fix '--target_board=native-extended-gdbserver/-m32'
Running the testsuite with the native-extended-gdbserver.exp board and
passing a variant spec, like
make check RUNTESTFLAGS="--target_board=native-extended-gdbserver/-m32"
results in dejagnu trying to open a rsh connection to
"native-extended-gdbserver", which of course is wrong. The point of
this board is running things locally.
The issue is that the native-extended-gdbserver board does not clear
the "isremote" flag properly.
Reported by Sergio at:
https://sourceware.org/ml/gdb-patches/2015-02/msg00067.html
testsuite/
2015-02-04 Pedro Alves <palves@redhat.com>
* boards/native-extended-gdbserver.exp: Remove any target variant
specifications from the board name before clearing the isremote
flag from board_info.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/testsuite/boards/native-extended-gdbserver.exp | 4 |
2 files changed, 9 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 2657987..fcc16cb 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-02-04 Pedro Alves <palves@redhat.com> + + * boards/native-extended-gdbserver.exp: Remove any target variant + specifications from the board name before clearing the isremote + flag from board_info. + 2015-01-31 Doug Evans <xdje42@gmail.com> * gdb.base/maint.exp <maint print type argc>: Update expected output. diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp index 57503db..8d299ef 100644 --- a/gdb/testsuite/boards/native-extended-gdbserver.exp +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp @@ -27,7 +27,9 @@ load_board_description "gdbserver-base" # matches localhost. Force it to be NOT remote. global board global board_info -set board_info($board,isremote) 0 +# Remove any target variant specifications from the name. +set baseboard [lindex [split $board "/"] 0] +set board_info($baseboard,isremote) 0 set_board_info sockethost "localhost:" |