diff options
| author | Gary Benson <gbenson@redhat.com> | 2018-10-10 15:01:50 +0100 |
|---|---|---|
| committer | Gary Benson <gbenson@redhat.com> | 2018-10-10 15:01:50 +0100 |
| commit | 33b031ce7a9b8b1b7c729518af965b7cb70a1cd6 (patch) | |
| tree | 554bbf8484a329d0959361946fb97765f6f5c486 | |
| parent | 2cb2ba9a5b7fe39f30604650efa64cff05cb72e4 (diff) | |
| download | gdb-33b031ce7a9b8b1b7c729518af965b7cb70a1cd6.zip gdb-33b031ce7a9b8b1b7c729518af965b7cb70a1cd6.tar.gz gdb-33b031ce7a9b8b1b7c729518af965b7cb70a1cd6.tar.bz2 | |
Add missing va_end found by Coverity
This commit adds a missing va_end found by Coverity.
gdb/ChangeLog:
* remote.c (remote_target::remote_send_printf): Add
missing va_end found by Coverity.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/remote.c | 6 |
2 files changed, 10 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc35510..aac5b7a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-10-10 Gary Benson <gbenson@redhat.com> + + * remote.c (remote_target::remote_send_printf): Add + missing va_end found by Coverity. + 2018-10-10 Markus Metzger <markus.t.metzger@intel.com> * btrace.c (ftrace_update_function): Add indirect jump heuristic. diff --git a/gdb/remote.c b/gdb/remote.c index 724f41c..c53553a 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8938,7 +8938,11 @@ remote_target::remote_send_printf (const char *format, ...) va_start (ap, format); rs->buf[0] = '\0'; - if (vsnprintf (rs->buf, max_size, format, ap) >= max_size) + int size = vsnprintf (rs->buf, max_size, format, ap); + + va_end (ap); + + if (size >= max_size) internal_error (__FILE__, __LINE__, _("Too long remote packet.")); if (putpkt (rs->buf) < 0) |