aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-07-08 12:16:20 -0600
committerTom Tromey <tom@tromey.com>2018-07-22 13:20:03 -0600
commitd5e9a511c4bbb25a7e6844169aa9e5b3fc7ef453 (patch)
tree072a94ae9e38bca417d8e31aecd237f5fdbe184b
parent996d693a07973411897103a36e89bccee6c94479 (diff)
downloadgdb-d5e9a511c4bbb25a7e6844169aa9e5b3fc7ef453.zip
gdb-d5e9a511c4bbb25a7e6844169aa9e5b3fc7ef453.tar.gz
gdb-d5e9a511c4bbb25a7e6844169aa9e5b3fc7ef453.tar.bz2
Call some functions in guile/ for effect
This changes a couple of spots in guile/ to remove a variable declaration but to still call a function for effect. gdb/ChangeLog 2018-07-22 Tom Tromey <tom@tromey.com> * guile/scm-cmd.c (gdbscm_dont_repeat): Call cmdscm_get_valid_command_smob_arg_unsafe for effect. * guile/scm-block.c (gdbscm_make_block_syms_iter): Call bkscm_get_valid_block_smob_arg_unsafe for effect.
-rw-r--r--gdb/ChangeLog7
-rw-r--r--gdb/guile/scm-block.c5
-rw-r--r--gdb/guile/scm-cmd.c6
3 files changed, 12 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8eb2cde..68edfcf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2018-07-22 Tom Tromey <tom@tromey.com>
+ * guile/scm-cmd.c (gdbscm_dont_repeat): Call
+ cmdscm_get_valid_command_smob_arg_unsafe for effect.
+ * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
+ bkscm_get_valid_block_smob_arg_unsafe for effect.
+
+2018-07-22 Tom Tromey <tom@tromey.com>
+
* bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
value_type.
diff --git a/gdb/guile/scm-block.c b/gdb/guile/scm-block.c
index d4566fc..9caff79 100644
--- a/gdb/guile/scm-block.c
+++ b/gdb/guile/scm-block.c
@@ -613,9 +613,8 @@ bkscm_block_syms_progress_p (SCM scm)
static SCM
gdbscm_make_block_syms_iter (SCM self)
{
- block_smob *b_smob
- = bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
- const struct block *block = b_smob->block;
+ /* Call for side effects. */
+ bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
SCM progress, iter;
progress = bkscm_make_block_syms_progress_smob ();
diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c
index 88a9864..4291933 100644
--- a/gdb/guile/scm-cmd.c
+++ b/gdb/guile/scm-cmd.c
@@ -267,9 +267,9 @@ gdbscm_command_valid_p (SCM self)
static SCM
gdbscm_dont_repeat (SCM self)
{
- /* We currently don't need anything from SELF, but still verify it. */
- command_smob *c_smob
- = cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
+ /* We currently don't need anything from SELF, but still verify it.
+ Call for side effects. */
+ cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
dont_repeat ();