diff options
| author | Doug Evans <dje@google.com> | 2012-05-29 20:23:17 +0000 |
|---|---|---|
| committer | Doug Evans <dje@google.com> | 2012-05-29 20:23:17 +0000 |
| commit | 98cc87bdf325f26e82368f9dcfa42fe3d497d53d (patch) | |
| tree | cde0a74a1d8e2247e3ea3c1449e8eafb34ac960c | |
| parent | 0a0edcd5c2947ab8fea2f080e121d7ade585e967 (diff) | |
| download | gdb-98cc87bdf325f26e82368f9dcfa42fe3d497d53d.zip gdb-98cc87bdf325f26e82368f9dcfa42fe3d497d53d.tar.gz gdb-98cc87bdf325f26e82368f9dcfa42fe3d497d53d.tar.bz2 | |
* buildsym.c (block_compar): Fix comment.
(end_symtab): Fix and clarify some comments.
| -rw-r--r-- | gdb/ChangeLog | 3 | ||||
| -rw-r--r-- | gdb/buildsym.c | 7 |
2 files changed, 7 insertions, 3 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b550855..b199f87 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2012-05-29 Doug Evans <dje@google.com> + * buildsym.c (block_compar): Fix comment. + (end_symtab): Fix and clarify some comments. + * stabsread.h (cleanup_undefined_stabs_types): Renamed from cleanup_undefined_types. * stabsread.c (cleanup_undefined_stabs_types): Ditto. diff --git a/gdb/buildsym.c b/gdb/buildsym.c index d41f26d..20fabb7 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -907,7 +907,7 @@ watch_main_source_file_lossage (void) } } -/* Helper function for qsort. Parametes are `struct block *' pointers, +/* Helper function for qsort. Parameters are `struct block *' pointers, function sorts them in descending order by their BLOCK_START. */ static int @@ -1126,7 +1126,7 @@ end_symtab (CORE_ADDR end_addr, struct objfile *objfile, int section) { /* Since we are ignoring that subfile, we also need to unlink the associated empty symtab that we created. - Otherwise, we can into trouble because various parts + Otherwise, we can run into trouble because various parts such as the block-vector are uninitialized whereas the rest of the code assumes that they are. @@ -1196,7 +1196,8 @@ end_symtab (CORE_ADDR end_addr, struct objfile *objfile, int section) SYMBOL_SYMTAB (BLOCK_FUNCTION (block)) = symtab; /* Note that we only want to fix up symbols from the local - blocks, not blocks coming from included symtabs. */ + blocks, not blocks coming from included symtabs. That is why + we use ALL_DICT_SYMBOLS here and not ALL_BLOCK_SYMBOLS. */ ALL_DICT_SYMBOLS (BLOCK_DICT (block), iter, sym) if (SYMBOL_SYMTAB (sym) == NULL) SYMBOL_SYMTAB (sym) = symtab; |