diff options
| author | Gary Benson <gbenson@redhat.com> | 2020-07-13 16:01:00 +0100 |
|---|---|---|
| committer | Gary Benson <gbenson@redhat.com> | 2020-07-13 16:01:00 +0100 |
| commit | f413dd7439e295849018caa01efa8d783e43f532 (patch) | |
| tree | 23126ea5b856a31a98454bf76147385baa115a50 | |
| parent | 915771bb8a8c14fce7af0d45967b955d0adc830b (diff) | |
| download | gdb-f413dd7439e295849018caa01efa8d783e43f532.zip gdb-f413dd7439e295849018caa01efa8d783e43f532.tar.gz gdb-f413dd7439e295849018caa01efa8d783e43f532.tar.bz2 | |
Fix gdb.base/savedregs.exp with clang
gdb.base/savedregs.exp fails to run with clang, because of:
gdb compile failed, /gdbtest/src/gdb/testsuite/gdb.base/savedregs.c:36:37:
warning: operator '<<' has lower precedence than '+'; '+' will be
evaluated first [-Wshift-op-parentheses]
return callee (a1 << a2 * a3 / a4 + a6 & a6 % a7 - a8) + done;
~~ ~~~~~~~~~~~~~^~~~
/gdbtest/build/gdb/testsuite/gdb.base/savedregs.c:36:37: note: place
parentheses around the '+' expression to silence this warning
return callee (a1 << a2 * a3 / a4 + a6 & a6 % a7 - a8) + done;
^
( )
1 warning generated.
This commit fixes it by adding the suggested parentheses.
gdb/testsuite/ChangeLog:
* gdb.base/savedregs.exp (caller): Use parentheses to
make expected expression evaluation ordering explicit.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/savedregs.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8fa0a46..dec5a44 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2020-07-13 Gary Benson <gbenson@redhat.com> + * gdb.base/savedregs.exp (caller): Use parentheses to + make expected expression evaluation ordering explicit. + +2020-07-13 Gary Benson <gbenson@redhat.com> + * gdb.arch/i386-sse.c (have_sse) <edx>: Make unsigned. 2020-07-13 Gary Benson <gbenson@redhat.com> diff --git a/gdb/testsuite/gdb.base/savedregs.c b/gdb/testsuite/gdb.base/savedregs.c index 05fba50..aec2a38 100644 --- a/gdb/testsuite/gdb.base/savedregs.c +++ b/gdb/testsuite/gdb.base/savedregs.c @@ -33,7 +33,7 @@ callee (int param) extern int caller (int a1, int a2, int a3, int a4, int a5, int a6, int a7, int a8) { - return callee (a1 << a2 * a3 / a4 + a6 & a6 % a7 - a8) + done; + return callee ((a1 << a2 * a3 / a4) + a6 & a6 % a7 - a8) + done; } static void |