diff options
| author | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-11-10 15:58:48 +0000 |
|---|---|---|
| committer | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-11-10 15:58:48 +0000 |
| commit | 89ce0c8f50b02eecbb87ad6246299fd214724846 (patch) | |
| tree | 74740b5ad2238c6d62afbed66c688b4c70abb4c7 | |
| parent | 27ed24c3649226227ff66f8ba53b4966ffd20c86 (diff) | |
| download | gdb-89ce0c8f50b02eecbb87ad6246299fd214724846.zip gdb-89ce0c8f50b02eecbb87ad6246299fd214724846.tar.gz gdb-89ce0c8f50b02eecbb87ad6246299fd214724846.tar.bz2 | |
gcc -Wall lint:
* thread.c: Include "gdbcmd.h" and <ctype.h>.
* Makefile.in: Update dependency.
* thread.c (thread_command): Remove unused variable p.
* values.c (unpack_double): Use len instead of TYPE_LENGTH (type).
* valprint.c (print_floating): Correctly check sign bit now that
we are using unsigned arithmetic.
* symtab.c (find_pc_line_range): Remove unused variables exact_match,
ind, and l.
| -rw-r--r-- | gdb/ChangeLog | 12 | ||||
| -rw-r--r-- | gdb/Makefile.in | 2 | ||||
| -rw-r--r-- | gdb/symtab.c | 3 | ||||
| -rw-r--r-- | gdb/thread.c | 3 | ||||
| -rw-r--r-- | gdb/values.c | 19 |
5 files changed, 26 insertions, 13 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 859dee6..844e055 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,15 @@ +Wed Nov 10 09:31:10 1993 Jim Kingdon (kingdon@lioth.cygnus.com) + + gcc -Wall lint: + * thread.c: Include "gdbcmd.h" and <ctype.h>. + * Makefile.in: Update dependency. + * thread.c (thread_command): Remove unused variable p. + * values.c (unpack_double): Use len instead of TYPE_LENGTH (type). + * valprint.c (print_floating): Correctly check sign bit now that + we are using unsigned arithmetic. + * symtab.c (find_pc_line_range): Remove unused variables exact_match, + ind, and l. + Tue Nov 9 17:42:25 1993 Kung Hsu (kung@cirdan.cygnus.com) * valarith.c (value_x_binop): fix search operator in class bug diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 6a83cfe..ac3ee3f 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1401,7 +1401,7 @@ tahoe-pinsn.o: tahoe-pinsn.c $(OP_INCLUDE)/tahoe.h $(defs_h) \ target.o: target.c $(bfd_h) $(defs_h) $(gdbcmd_h) $(inferior_h) \ objfiles.h symfile.h target.h -thread.o: thread.c $(defs_h) thread.h +thread.o: thread.c $(defs_h) thread.h $(gdbcmd_h) typeprint.o: typeprint.c $(defs_h) $(expression_h) $(gdbcmd_h) \ $(gdbcore_h) $(gdbtypes_h) language.h $(symtab_h) target.h \ diff --git a/gdb/symtab.c b/gdb/symtab.c index 582ca04..2dcc877 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -1284,9 +1284,6 @@ find_line_pc_range (sal, startptr, endptr) struct symtab_and_line sal; CORE_ADDR *startptr, *endptr; { - struct linetable *l; - int ind; - int exact_match; /* did we get an exact linenumber match */ CORE_ADDR startaddr; struct symtab_and_line found_sal; diff --git a/gdb/thread.c b/gdb/thread.c index a060bec..c3d52c3 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -29,7 +29,9 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #include "target.h" #include "thread.h" #include "command.h" +#include "gdbcmd.h" +#include <ctype.h> #include <sys/types.h> #include <signal.h> @@ -323,7 +325,6 @@ thread_command (tidstr, from_tty) { int num; struct thread_info *tp; - char *p; if (!tidstr) error ("Please specify a thread ID. Use the \"info threads\" command to\n\ diff --git a/gdb/values.c b/gdb/values.c index 494f5bd..7191aba 100644 --- a/gdb/values.c +++ b/gdb/values.c @@ -647,15 +647,18 @@ unpack_double (type, valaddr, invp) *invp = 1; return 1.234567891011121314; } - return extract_floating (valaddr, TYPE_LENGTH (type)); + return extract_floating (valaddr, len); + } + else if (nosign) + { + /* Unsigned -- be sure we compensate for signed LONGEST. */ + return (unsigned LONGEST) unpack_long (type, valaddr); + } + else + { + /* Signed -- we are OK with unpack_long. */ + return unpack_long (type, valaddr); } - else if (nosign) { - /* Unsigned -- be sure we compensate for signed LONGEST. */ - return (unsigned LONGEST) unpack_long (type, valaddr); - } else { - /* Signed -- we are OK with unpack_long. */ - return unpack_long (type, valaddr); - } } /* Unpack raw data (copied from debugee, target byte order) at VALADDR |