diff options
author | Daniel Jacobowitz <drow@false.org> | 2005-03-25 21:28:50 +0000 |
---|---|---|
committer | Daniel Jacobowitz <drow@false.org> | 2005-03-25 21:28:50 +0000 |
commit | b3a052a629201a6c2d2d6eea3aaa816a79d760d9 (patch) | |
tree | 7c8615639b35c1b0b516dd61d1b7e061c329c117 | |
parent | a5975c228f0ba8cb421c6339351e2a930907ae24 (diff) | |
download | gdb-b3a052a629201a6c2d2d6eea3aaa816a79d760d9.zip gdb-b3a052a629201a6c2d2d6eea3aaa816a79d760d9.tar.gz gdb-b3a052a629201a6c2d2d6eea3aaa816a79d760d9.tar.bz2 |
* gdb/arm-tdep.c (target_is_thumb, caller_is_thumb)
(arm_pc_is_thumb_dummy): Remove.
(arm_breakpoint_from_pc): Don't call arm_pc_is_thumb_dummy.
-rw-r--r-- | ChangeLog.csl | 6 | ||||
-rw-r--r-- | gdb/arm-tdep.c | 37 |
2 files changed, 7 insertions, 36 deletions
diff --git a/ChangeLog.csl b/ChangeLog.csl index af34fdf..3822724 100644 --- a/ChangeLog.csl +++ b/ChangeLog.csl @@ -1,5 +1,11 @@ 2005-03-25 Daniel Jacobowitz <dan@codesourcery.com> + * gdb/arm-tdep.c (target_is_thumb, caller_is_thumb) + (arm_pc_is_thumb_dummy): Remove. + (arm_breakpoint_from_pc): Don't call arm_pc_is_thumb_dummy. + +2005-03-25 Daniel Jacobowitz <dan@codesourcery.com> + * gdb/arm-linux-tdep.c (arm_linux_thumb_be_breakpoint) (arm_linux_thumb_le_breakpoint): New. Update comments. (arm_linux_init_abi): Set Thumb breakpoints also. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 1f5f799..fc7e8fe 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -184,20 +184,6 @@ struct arm_prologue_cache int arm_apcs_32 = 1; -/* Flag set by arm_fix_call_dummy that tells whether the target - function is a Thumb function. This flag is checked by - arm_push_arguments. FIXME: Change the PUSH_ARGUMENTS macro (and - its use in valops.c) to pass the function address as an additional - parameter. */ - -static int target_is_thumb; - -/* Flag set by arm_fix_call_dummy that tells whether the calling - function is a Thumb function. This flag is checked by - arm_pc_is_thumb. */ - -static int caller_is_thumb; - /* Determine if the program counter specified in MEMADDR is in a Thumb function. */ @@ -222,27 +208,6 @@ arm_pc_is_thumb (CORE_ADDR memaddr) } } -/* Determine if the program counter specified in MEMADDR is in a call - dummy being called from a Thumb function. */ - -int -arm_pc_is_thumb_dummy (CORE_ADDR memaddr) -{ - CORE_ADDR sp = read_sp (); - - /* FIXME: Until we switch for the new call dummy macros, this heuristic - is the best we can do. We are trying to determine if the pc is on - the stack, which (hopefully) will only happen in a call dummy. - We hope the current stack pointer is not so far alway from the dummy - frame location (true if we have not pushed large data structures or - gone too many levels deep) and that our 1024 is not enough to consider - code regions as part of the stack (true for most practical purposes). */ - if (deprecated_pc_in_call_dummy (memaddr)) - return caller_is_thumb; - else - return 0; -} - /* Remove useless bits from addresses in a running program. */ static CORE_ADDR arm_addr_bits_remove (CORE_ADDR val) @@ -2016,7 +1981,7 @@ arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr) { struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); - if (arm_pc_is_thumb (*pcptr) || arm_pc_is_thumb_dummy (*pcptr)) + if (arm_pc_is_thumb (*pcptr)) { *pcptr = UNMAKE_THUMB_ADDR (*pcptr); *lenptr = tdep->thumb_breakpoint_size; |