diff options
author | Alan Modra <amodra@gmail.com> | 2017-02-22 08:10:58 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2017-02-22 10:01:18 +1030 |
commit | d72ca87af2af8d8fb1e0eb9842d37045fc1d2dd1 (patch) | |
tree | aa9b3adc0587044e1853192016e2a575fbf58df2 | |
parent | d29655b6c3564dc00ff538822c3d383e74697425 (diff) | |
download | gdb-d72ca87af2af8d8fb1e0eb9842d37045fc1d2dd1.zip gdb-d72ca87af2af8d8fb1e0eb9842d37045fc1d2dd1.tar.gz gdb-d72ca87af2af8d8fb1e0eb9842d37045fc1d2dd1.tar.bz2 |
PowerPC ld segfault on script discarding dynamic sections
bfd/
* elf64-ppc.c (ppc64_elf_finish_dynamic_sections): Don't segfault
on .got or .plt output section being discarded by script.
* elf32-ppc.c (ppc_elf_finish_dynamic_sections): Likewise. Move
vxworks splt temp.
gold/
* powerpc.cc (Target_powerpc::make_iplt_section): Check that
output_section exists before attempting add_output_section_data.
(Target_powerpc::make_brlt_section): Likewise.
-rw-r--r-- | bfd/ChangeLog | 7 | ||||
-rw-r--r-- | bfd/elf32-ppc.c | 15 | ||||
-rw-r--r-- | bfd/elf64-ppc.c | 6 | ||||
-rw-r--r-- | gold/ChangeLog | 4 | ||||
-rw-r--r-- | gold/powerpc.cc | 14 |
5 files changed, 32 insertions, 14 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index c511b26..d8e4e99 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2017-02-22 Alan Modra <amodra@gmail.com> + + * elf64-ppc.c (ppc64_elf_finish_dynamic_sections): Don't segfault + on .got or .plt output section being discarded by script. + * elf32-ppc.c (ppc_elf_finish_dynamic_sections): Likewise. Move + vxworks splt temp. + 2017-02-21 Alan Modra <amodra@gmail.com> Apply from master diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index e42ef1c..8b19105 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -10303,11 +10303,6 @@ ppc_elf_finish_dynamic_sections (bfd *output_bfd, htab = ppc_elf_hash_table (info); dynobj = elf_hash_table (info)->dynobj; sdyn = bfd_get_linker_section (dynobj, ".dynamic"); - if (htab->is_vxworks) - splt = bfd_get_linker_section (dynobj, ".plt"); - else - splt = NULL; - got = 0; if (htab->elf.hgot != NULL) got = SYM_VAL (htab->elf.hgot); @@ -10370,7 +10365,8 @@ ppc_elf_finish_dynamic_sections (bfd *output_bfd, } } - if (htab->got != NULL) + if (htab->got != NULL + && htab->got->output_section != bfd_abs_section_ptr) { if (htab->elf.hgot->root.u.def.section == htab->got || htab->elf.hgot->root.u.def.section == htab->sgotplt) @@ -10410,7 +10406,12 @@ ppc_elf_finish_dynamic_sections (bfd *output_bfd, } /* Fill in the first entry in the VxWorks procedure linkage table. */ - if (splt && splt->size > 0) + splt = NULL; + if (htab->is_vxworks) + splt = bfd_get_linker_section (dynobj, ".plt"); + if (splt != NULL + && splt->size != 0 + && splt->output_section != bfd_abs_section_ptr) { /* Use the right PLT. */ const bfd_vma *plt_entry = (bfd_link_pic (info) diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index dbd4230..0b7f1d7 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -15532,7 +15532,8 @@ ppc64_elf_finish_dynamic_sections (bfd *output_bfd, } } - if (htab->elf.sgot != NULL && htab->elf.sgot->size != 0) + if (htab->elf.sgot != NULL && htab->elf.sgot->size != 0 + && htab->elf.sgot->output_section != bfd_abs_section_ptr) { /* Fill in the first entry in the global offset table. We use it to hold the link-time TOCbase. */ @@ -15544,7 +15545,8 @@ ppc64_elf_finish_dynamic_sections (bfd *output_bfd, elf_section_data (htab->elf.sgot->output_section)->this_hdr.sh_entsize = 8; } - if (htab->elf.splt != NULL && htab->elf.splt->size != 0) + if (htab->elf.splt != NULL && htab->elf.splt->size != 0 + && htab->elf.splt->output_section != bfd_abs_section_ptr) { /* Set .plt entry size. */ elf_section_data (htab->elf.splt->output_section)->this_hdr.sh_entsize diff --git a/gold/ChangeLog b/gold/ChangeLog index 30d3244..59c60e7 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,6 +1,10 @@ 2017-02-22 Alan Modra <amodra@gmail.com> Apply from master + * powerpc.cc (Target_powerpc::make_iplt_section): Check that + output_section exists before attempting add_output_section_data. + (Target_powerpc::make_brlt_section): Likewise. + 2017-02-03 Alan Modra <amodra@gmail.com> * powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash when no .toc section exists. diff --git a/gold/powerpc.cc b/gold/powerpc.cc index 81f9bff..2c70f9f 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc @@ -3608,11 +3608,13 @@ Target_powerpc<size, big_endian>::make_iplt_section(Symbol_table* symtab, this->make_plt_section(symtab, layout); Reloc_section* iplt_rel = new Reloc_section(false); - this->rela_dyn_->output_section()->add_output_section_data(iplt_rel); + if (this->rela_dyn_->output_section()) + this->rela_dyn_->output_section()->add_output_section_data(iplt_rel); this->iplt_ = new Output_data_plt_powerpc<size, big_endian>(this, iplt_rel, "** IPLT"); - this->plt_->output_section()->add_output_section_data(this->iplt_); + if (this->plt_->output_section()) + this->plt_->output_section()->add_output_section_data(this->iplt_); } } @@ -3708,14 +3710,16 @@ Target_powerpc<size, big_endian>::make_brlt_section(Layout* layout) { // When PIC we can't fill in .branch_lt (like .plt it can be // a bss style section) but must initialise at runtime via - // dynamic relocats. + // dynamic relocations. this->rela_dyn_section(layout); brlt_rel = new Reloc_section(false); - this->rela_dyn_->output_section()->add_output_section_data(brlt_rel); + if (this->rela_dyn_->output_section()) + this->rela_dyn_->output_section() + ->add_output_section_data(brlt_rel); } this->brlt_section_ = new Output_data_brlt_powerpc<size, big_endian>(this, brlt_rel); - if (this->plt_ && is_pic) + if (this->plt_ && is_pic && this->plt_->output_section()) this->plt_->output_section() ->add_output_section_data(this->brlt_section_); else |