From afa1ee5e6f7e89794d377dc804801367af84dfdd Mon Sep 17 00:00:00 2001 From: Bryce McKinlay Date: Wed, 24 Sep 2003 06:19:24 +0000 Subject: StringBuffer.java (substring): Don't set `shared' on small Strings, even if buffer is already shared. * java/lang/StringBuffer.java (substring): Don't set `shared' on small Strings, even if buffer is already shared. From-SVN: r71726 --- libjava/java/lang/StringBuffer.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'libjava/java/lang/StringBuffer.java') diff --git a/libjava/java/lang/StringBuffer.java b/libjava/java/lang/StringBuffer.java index a7c2590..0903b40 100644 --- a/libjava/java/lang/StringBuffer.java +++ b/libjava/java/lang/StringBuffer.java @@ -564,11 +564,12 @@ public final class StringBuffer implements Serializable, CharSequence throw new StringIndexOutOfBoundsException(); if (len == 0) return ""; - // Share unless substring is smaller than 1/4 of the buffer. - if ((len << 2) >= value.length) - shared = true; + // Don't copy unless substring is smaller than 1/4 of the buffer. + boolean share_buffer = ((len << 2) >= value.length); + if (share_buffer) + this.shared = true; // Package constructor avoids an array copy. - return new String(value, beginIndex, len, shared); + return new String(value, beginIndex, len, share_buffer); } /** -- cgit v1.1