From abfe01cec91fae69bb05700bf6a53f41a64fd15c Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Wed, 3 Feb 2010 15:42:35 -0500 Subject: re PR c++/12909 (ambiguity in mangling vector types) PR c++/12909 * mangle.c (write_type) [VECTOR_TYPE]: Change mangling. From-SVN: r156481 --- libiberty/ChangeLog | 6 ++++ libiberty/cp-demangle.c | 66 ++++++++++++++++++++++++++++++++--- libiberty/testsuite/demangle-expected | 6 ++++ 3 files changed, 73 insertions(+), 5 deletions(-) (limited to 'libiberty') diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index fcbef26..d4a43ec 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,9 @@ +2010-02-03 Jason Merrill + + PR c++/12909 + * cp-demangle.c (d_number_component, d_vector_type): New. + (cplus_demangle_type, d_print_comp, d_print_mod): Handle vectors. + 2010-01-25 Ian Lance Taylor * cp-demangle.c (cplus_demangle_type): Check for invalid type diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 2f4d0cc..75706b3 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -389,6 +389,8 @@ d_class_enum_type (struct d_info *); static struct demangle_component *d_array_type (struct d_info *); +static struct demangle_component *d_vector_type (struct d_info *); + static struct demangle_component * d_pointer_to_member_type (struct d_info *); @@ -796,6 +798,7 @@ d_make_comp (struct d_info *di, enum demangle_component_type type, case DEMANGLE_COMPONENT_LITERAL: case DEMANGLE_COMPONENT_LITERAL_NEG: case DEMANGLE_COMPONENT_COMPOUND_NAME: + case DEMANGLE_COMPONENT_VECTOR_TYPE: if (left == NULL || right == NULL) return NULL; break; @@ -1442,6 +1445,20 @@ d_number (struct d_info *di) } } +/* Like d_number, but returns a demangle_component. */ + +static struct demangle_component * +d_number_component (struct d_info *di) +{ + struct demangle_component *ret = d_make_empty (di); + if (ret) + { + ret->type = DEMANGLE_COMPONENT_NUMBER; + ret->u.s_number.number = d_number (di); + } + return ret; +} + /* identifier ::= <(unqualified source code identifier)> */ static struct demangle_component * @@ -2200,6 +2217,10 @@ cplus_demangle_type (struct d_info *di) ret->u.s_fixed.sat = (peek == 's'); break; + case 'v': + ret = d_vector_type (di); + break; + default: return NULL; } @@ -2418,6 +2439,34 @@ d_array_type (struct d_info *di) cplus_demangle_type (di)); } +/* ::= Dv _ + ::= Dv _ _ */ + +static struct demangle_component * +d_vector_type (struct d_info *di) +{ + char peek; + struct demangle_component *dim; + + peek = d_peek_char (di); + if (peek == '_') + { + d_advance (di, 1); + dim = d_expression (di); + } + else + dim = d_number_component (di); + + if (dim == NULL) + return NULL; + + if (! d_check_char (di, '_')) + return NULL; + + return d_make_comp (di, DEMANGLE_COMPONENT_VECTOR_TYPE, dim, + cplus_demangle_type (di)); +} + /* ::= M <(class) type> <(member) type> */ static struct demangle_component * @@ -3930,6 +3979,7 @@ d_print_comp (struct d_print_info *dpi, } case DEMANGLE_COMPONENT_PTRMEM_TYPE: + case DEMANGLE_COMPONENT_VECTOR_TYPE: { struct d_print_mod dpm; @@ -3944,11 +3994,7 @@ d_print_comp (struct d_print_info *dpi, /* If the modifier didn't get printed by the type, print it now. */ if (! dpm.printed) - { - d_append_char (dpi, ' '); - d_print_comp (dpi, d_left (dc)); - d_append_string (dpi, "::*"); - } + d_print_mod (dpi, dc); dpi->modifiers = dpm.next; @@ -4168,6 +4214,10 @@ d_print_comp (struct d_print_info *dpi, } return; + case DEMANGLE_COMPONENT_NUMBER: + d_append_num (dpi, dc->u.s_number.number); + return; + case DEMANGLE_COMPONENT_JAVA_RESOURCE: d_append_string (dpi, "java resource "); d_print_comp (dpi, d_left (dc)); @@ -4440,6 +4490,12 @@ d_print_mod (struct d_print_info *dpi, case DEMANGLE_COMPONENT_TYPED_NAME: d_print_comp (dpi, d_left (mod)); return; + case DEMANGLE_COMPONENT_VECTOR_TYPE: + d_append_string (dpi, " vector["); + d_print_comp (dpi, d_left (mod)); + d_append_char (dpi, ']'); + return; + default: /* Otherwise, we have something that won't go back on the modifier stack, so we can just print it. */ diff --git a/libiberty/testsuite/demangle-expected b/libiberty/testsuite/demangle-expected index eaa7ca9..3662f16 100644 --- a/libiberty/testsuite/demangle-expected +++ b/libiberty/testsuite/demangle-expected @@ -3926,6 +3926,12 @@ S::x::{lambda()#3}::operator()() const --format=gnu-v3 _Z1fN1SUt_E f(S::{unnamed type#1}) +--format=gnu-v3 +_Z1fDv32_f +f(float vector[32]) +--format=gnu-v3 +_Z1fIfLi4EEvDv_T0__T_ +void f(float vector[4]) # # Ada (GNAT) tests. # -- cgit v1.1