From 86187d0fe0984bc90f70b3742ef09b06e0bbb673 Mon Sep 17 00:00:00 2001 From: Tobias Burnus Date: Mon, 29 Aug 2011 12:33:09 +0200 Subject: trans-decl.c (generate_coarray_sym_init): Use GFC_CAF_COARRAY_STATIC for static coarrays. gcc/fortran/ 2011-08-29 Tobias Burnus * trans-decl.c (generate_coarray_sym_init): Use GFC_CAF_COARRAY_STATIC for static coarrays. libgfortan/ 2011-08-29 Tobias Burnus * caf/libcaf.h (_gfortran_caf_deregister): Update prototype. * caf/mpi.c (_gfortran_caf_deregister): Modify prototype, actually free memory and add error diagnostic. (_gfortran_caf_finalize): Add additional free calls. * caf/single.c (_gfortran_caf_deregister): Modify prototype, actually free memory and add error diagnostic. (_gfortran_caf_finalize): Add additional free calls. From-SVN: r178193 --- libgfortran/ChangeLog | 10 ++++++++++ libgfortran/caf/libcaf.h | 2 +- libgfortran/caf/mpi.c | 43 +++++++++++++++++++++++++++++++++++++------ libgfortran/caf/single.c | 19 ++++++++++++++----- 4 files changed, 62 insertions(+), 12 deletions(-) (limited to 'libgfortran') diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog index 6c57beb..f20713e5 100644 --- a/libgfortran/ChangeLog +++ b/libgfortran/ChangeLog @@ -1,3 +1,13 @@ +2011-08-29 Tobias Burnus + + * caf/libcaf.h (_gfortran_caf_deregister): Update prototype. + * caf/mpi.c (_gfortran_caf_deregister): Modify prototype, + actually free memory and add error diagnostic. + (_gfortran_caf_finalize): Add additional free calls. + * caf/single.c (_gfortran_caf_deregister): Modify prototype, + actually free memory and add error diagnostic. + (_gfortran_caf_finalize): Add additional free calls. + 2011-08-29 Thomas Koenig PR libfortran/50192 diff --git a/libgfortran/caf/libcaf.h b/libgfortran/caf/libcaf.h index 4fe09e4..e6be7ce 100644 --- a/libgfortran/caf/libcaf.h +++ b/libgfortran/caf/libcaf.h @@ -69,7 +69,7 @@ void _gfortran_caf_finalize (void); void * _gfortran_caf_register (ptrdiff_t, caf_register_t, void **, int *, char *, int); -int _gfortran_caf_deregister (void **); +void _gfortran_caf_deregister (void **, int *, char *, int); void _gfortran_caf_sync_all (int *, char *, int); diff --git a/libgfortran/caf/mpi.c b/libgfortran/caf/mpi.c index ea4c0f0..c69c5b9 100644 --- a/libgfortran/caf/mpi.c +++ b/libgfortran/caf/mpi.c @@ -103,8 +103,12 @@ _gfortran_caf_finalize (void) { while (caf_static_list != NULL) { - free(caf_static_list->token[caf_this_image-1]); - caf_static_list = caf_static_list->prev; + caf_static_t *tmp = caf_static_list->prev; + + free (caf_static_list->token[caf_this_image-1]); + free (caf_static_list->token); + free (caf_static_list); + caf_static_list = tmp; } if (!caf_mpi_initialized) @@ -187,10 +191,37 @@ error: } -int -_gfortran_caf_deregister (void **token __attribute__ ((unused))) +void +_gfortran_caf_deregister (void **token, int *stat, char *errmsg, int errmsg_len) { - return 0; + if (unlikely (caf_is_finalized)) + { + const char msg[] = "Failed to deallocate coarray - " + "there are stopped images"; + if (stat) + { + *stat = STAT_STOPPED_IMAGE; + + if (errmsg_len > 0) + { + int len = ((int) sizeof (msg) - 1 > errmsg_len) + ? errmsg_len : (int) sizeof (msg) - 1; + memcpy (errmsg, msg, len); + if (errmsg_len > len) + memset (&errmsg[len], ' ', errmsg_len-len); + } + return; + } + caf_runtime_error (msg); + } + + _gfortran_caf_sync_all (NULL, NULL, 0); + + if (stat) + *stat = 0; + + free (token[caf_this_image-1]); + free (token); } @@ -267,7 +298,7 @@ _gfortran_caf_sync_images (int count, int images[], int *stat, char *errmsg, } /* Handle SYNC IMAGES(*). */ - if (unlikely(caf_is_finalized)) + if (unlikely (caf_is_finalized)) ierr = STAT_STOPPED_IMAGE; else ierr = MPI_Barrier (MPI_COMM_WORLD); diff --git a/libgfortran/caf/single.c b/libgfortran/caf/single.c index 09cc62f..5353c7b 100644 --- a/libgfortran/caf/single.c +++ b/libgfortran/caf/single.c @@ -71,8 +71,11 @@ _gfortran_caf_finalize (void) { while (caf_static_list != NULL) { - free(caf_static_list->token[0]); - caf_static_list = caf_static_list->prev; + caf_static_t *tmp = caf_static_list->prev; + free (caf_static_list->token[0]); + free (caf_static_list->token); + free (caf_static_list); + caf_static_list = tmp; } } @@ -121,10 +124,16 @@ _gfortran_caf_register (ptrdiff_t size, caf_register_t type, void **token, } -int -_gfortran_caf_deregister (void **token __attribute__ ((unused))) +void +_gfortran_caf_deregister (void **token, int *stat, + char *errmsg __attribute__ ((unused)), + int errmsg_len __attribute__ ((unused))) { - return 0; + free (*token); + free (token); + + if (stat) + *stat = 0; } -- cgit v1.1