From f6efea5163e7a321ecda80386ac23488e041ec2b Mon Sep 17 00:00:00 2001 From: Markus Trippelsdorf Date: Wed, 18 Jan 2017 08:40:05 +0000 Subject: Fix PR77489 -- mangling of discriminator >= 1 libiberty: PR c++/77489 * cp-demangle.c (d_discriminator): Handle discriminator >= 10. * testsuite/demangle-expected: Add tests for discriminator. gcc: PR c++/77489 * doc/invoke.texi (fabi-version): Document discriminator mangling. gcc/cp: PR c++/77489 * mangle.c (write_discriminator): Handle discriminator >= 10. From-SVN: r244566 --- gcc/ChangeLog | 5 +++ gcc/cp/ChangeLog | 5 +++ gcc/cp/mangle.c | 11 ++++++- gcc/doc/invoke.texi | 4 ++- gcc/testsuite/g++.dg/abi/pr77489.C | 63 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 86 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/abi/pr77489.C (limited to 'gcc') diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e2ea014..13a7015 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2017-01-18 Markus Trippelsdorf + + PR c++/77489 + * doc/invoke.texi (fabi-version): Document discriminator mangling. + 2017-01-17 Segher Boessenkool PR target/78875 diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index d24b2ae..86669ae 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2017-01-18 Markus Trippelsdorf + + PR c++/77489 + * mangle.c (write_discriminator): Handle discriminator >= 10. + 2017-01-17 Nathan Sidwell PR c++/61636 diff --git a/gcc/cp/mangle.c b/gcc/cp/mangle.c index 5f2fa35..67ec5c3 100644 --- a/gcc/cp/mangle.c +++ b/gcc/cp/mangle.c @@ -1952,7 +1952,8 @@ discriminator_for_string_literal (tree /*function*/, return 0; } -/* := _ +/* := _ # when number < 10 + := __ _ # when number >= 10 The discriminator is used only for the second and later occurrences of the same name within a single function. In this case is @@ -1965,7 +1966,15 @@ write_discriminator (const int discriminator) if (discriminator > 0) { write_char ('_'); + if (abi_version_at_least (11) && discriminator - 1 >= 10) + { + write_char ('_'); + if (abi_warn_or_compat_version_crosses (11)) + G.need_abi_warning = 1; + } write_unsigned_number (discriminator - 1); + if (abi_version_at_least (11) && discriminator - 1 >= 10) + write_char ('_'); } } diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index cac3d8b..767c8f4 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -2252,7 +2252,9 @@ attributes that affect type identity, such as ia32 calling convention attributes (e.g. @samp{stdcall}). Version 11, which first appeared in G++ 7, corrects the mangling of -sizeof... expressions. It also implies +sizeof... expressions. For multiple entities with the same name within +a function, that are declared in different scopes, the mangling now +changes starting with the eighth occurence. It also implies @option{-fnew-inheriting-ctors}. See also @option{-Wabi}. diff --git a/gcc/testsuite/g++.dg/abi/pr77489.C b/gcc/testsuite/g++.dg/abi/pr77489.C new file mode 100644 index 0000000..13c41cc --- /dev/null +++ b/gcc/testsuite/g++.dg/abi/pr77489.C @@ -0,0 +1,63 @@ +// { dg-options -fabi-version=11 } + +extern void bar(int*); + +void foo() +{ + { + static int localVar = 0; + bar(&localVar); + } + { + static int localVar = 1; + bar(&localVar); + } + { + static int localVar = 2; + bar(&localVar); + } + { + static int localVar = 3; + bar(&localVar); + } + { + static int localVar = 4; + bar(&localVar); + } + { + static int localVar = 5; + bar(&localVar); + } + { + static int localVar = 6; + bar(&localVar); + } + { + static int localVar = 7; + bar(&localVar); + } + { + static int localVar = 8; + bar(&localVar); + } + { + static int localVar = 9; + bar(&localVar); + } + { + static int localVar = 10; + bar(&localVar); + } + { + static int localVar = 11; + bar(&localVar); + } + { + static int localVar = 12; + bar(&localVar); + } +} + +// { dg-final { scan-assembler "_ZZ3foovE8localVar_9" } } +// { dg-final { scan-assembler "_ZZ3foovE8localVar__10_" } } +// { dg-final { scan-assembler "_ZZ3foovE8localVar__11_" } } -- cgit v1.1