From f19319dbdf17b98c1b3df97c2297bf3f72d83c85 Mon Sep 17 00:00:00 2001 From: Gabriel Dos Reis Date: Mon, 14 Jul 2003 15:04:32 +0000 Subject: re PR c++/5293 (confusing message when binding a temporary to a reference) PR c++/5293 * call.c (initialize_reference): Improve diagnostic. From-SVN: r69332 --- gcc/cp/ChangeLog | 5 +++++ gcc/cp/call.c | 8 +++++++- gcc/testsuite/g++.dg/init/ref8.C | 10 ++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/init/ref8.C (limited to 'gcc') diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 8cc0234..2627e94 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2003-07-14 Gabriel Dos Reis + + PR c++/5293 + * call.c (initialize_reference): Improve diagnostic. + 2003-07-14 Kriang Lerdsuwanakij PR c++/11154 diff --git a/gcc/cp/call.c b/gcc/cp/call.c index 39f8221..c71b3f8 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -6035,7 +6035,13 @@ initialize_reference (tree type, tree expr, tree decl) conv = reference_binding (type, TREE_TYPE (expr), expr, LOOKUP_NORMAL); if (!conv || ICS_BAD_FLAG (conv)) { - error ("could not convert `%E' to `%T'", expr, type); + if (!(TYPE_QUALS (TREE_TYPE (type)) & TYPE_QUAL_CONST) + && !real_lvalue_p (expr)) + error ("invalid initialization of non-const reference of " + "type '%T' from a temporary of type '%T'", + type, TREE_TYPE (expr)); + else + error ("could not convert `%E' to `%T'", expr, type); return error_mark_node; } diff --git a/gcc/testsuite/g++.dg/init/ref8.C b/gcc/testsuite/g++.dg/init/ref8.C new file mode 100644 index 0000000..406cc10 --- /dev/null +++ b/gcc/testsuite/g++.dg/init/ref8.C @@ -0,0 +1,10 @@ +struct A { + A operator=(const A&); +}; + +A operator*(A, A); + +A& operator+=(A& a, const A& b) +{ + return a = a * b; // { dg-error "non-const reference" } +} -- cgit v1.1