From eb153f07b3618de080b778ffff5693d94bf785b4 Mon Sep 17 00:00:00 2001 From: Jim Wilson Date: Tue, 3 Jul 2018 00:19:59 +0000 Subject: RISC-V: Fix interrupt support for -g. gcc/ * config/riscv/riscv.c (riscv_expand_epilogue): Use emit_jump_insn instead of emit_insn for interrupt returns. * config/riscv/riscv.md (riscv_met): Add (return) to rtl. (riscv_sret, riscv_uret): Likewise. gcc/testsuite/ * gcc.target/riscv/interrupt-debug.c: New. From-SVN: r262327 --- gcc/ChangeLog | 7 +++++++ gcc/config/riscv/riscv.c | 6 +++--- gcc/config/riscv/riscv.md | 9 ++++++--- gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/gcc.target/riscv/interrupt-debug.c | 15 +++++++++++++++ 5 files changed, 35 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gcc.target/riscv/interrupt-debug.c (limited to 'gcc') diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e0b5c65..a8c2629 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2018-07-02 Jim Wilson + + * config/riscv/riscv.c (riscv_expand_epilogue): Use emit_jump_insn + instead of emit_insn for interrupt returns. + * config/riscv/riscv.md (riscv_met): Add (return) to rtl. + (riscv_sret, riscv_uret): Likewise. + 2018-07-02 David Malcolm * pretty-print.c (selftest::test_pp_format): Move save and restore diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c index 2709ebd..d87836f 100644 --- a/gcc/config/riscv/riscv.c +++ b/gcc/config/riscv/riscv.c @@ -3985,11 +3985,11 @@ riscv_expand_epilogue (int style) enum riscv_privilege_levels mode = cfun->machine->interrupt_mode; if (mode == MACHINE_MODE) - emit_insn (gen_riscv_mret ()); + emit_jump_insn (gen_riscv_mret ()); else if (mode == SUPERVISOR_MODE) - emit_insn (gen_riscv_sret ()); + emit_jump_insn (gen_riscv_sret ()); else - emit_insn (gen_riscv_uret ()); + emit_jump_insn (gen_riscv_uret ()); } else if (style != SIBCALL_RETURN) emit_jump_insn (gen_simple_return_internal (ra)); diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md index 7b411f0..613af9d 100644 --- a/gcc/config/riscv/riscv.md +++ b/gcc/config/riscv/riscv.md @@ -2328,17 +2328,20 @@ "fsflags\t%0") (define_insn "riscv_mret" - [(unspec_volatile [(const_int 0)] UNSPECV_MRET)] + [(return) + (unspec_volatile [(const_int 0)] UNSPECV_MRET)] "" "mret") (define_insn "riscv_sret" - [(unspec_volatile [(const_int 0)] UNSPECV_SRET)] + [(return) + (unspec_volatile [(const_int 0)] UNSPECV_SRET)] "" "sret") (define_insn "riscv_uret" - [(unspec_volatile [(const_int 0)] UNSPECV_URET)] + [(return) + (unspec_volatile [(const_int 0)] UNSPECV_URET)] "" "uret") diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index f2485db..fb4422f 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-07-02 Jim Wilson + + * gcc.target/riscv/interrupt-debug.c: New. + 2018-07-02 Paolo Carlini * g++.dg/diagnostic/thread-thread_local.C: New. diff --git a/gcc/testsuite/gcc.target/riscv/interrupt-debug.c b/gcc/testsuite/gcc.target/riscv/interrupt-debug.c new file mode 100644 index 0000000..a1b6dac --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/interrupt-debug.c @@ -0,0 +1,15 @@ +/* Verify that we can compile with debug info. */ +/* { dg-do compile } */ +/* { dg-options "-Og -g" } */ +extern int var1; +extern int var2; +extern void sub2 (void); + +void __attribute__ ((interrupt)) +sub (void) +{ + if (var1) + var2 = 0; + else + sub2 (); +} -- cgit v1.1