From c3b07ec29f81ef3c0a392c5989ae825b2f7c8195 Mon Sep 17 00:00:00 2001 From: Geoffrey Keating Date: Tue, 9 Oct 2007 22:56:58 +0000 Subject: Index: gcc/ChangeLog 2007-10-09 Geoffrey Keating * dwarf2out.c (output_call_frame_info): FDEs are always emitted if flag_exceptions is not set. * config/darwin.c (darwin_emit_unwind_label): Rewrite to use assemble_name rather than incorrectly emulating it. Index: gcc/testsuite/ChangeLog 2007-10-09 Geoffrey Keating * gcc.dg/unwind-1.c: New. From-SVN: r129187 --- gcc/ChangeLog | 5 +++++ gcc/config/darwin.c | 46 +++++++++++++++++------------------------ gcc/dwarf2out.c | 1 + gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/gcc.dg/unwind-1.c | 7 +++++++ 5 files changed, 36 insertions(+), 27 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/unwind-1.c (limited to 'gcc') diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7595600..cb9b878 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2007-10-09 Geoffrey Keating + * dwarf2out.c (output_call_frame_info): FDEs are always emitted + if flag_exceptions is not set. + * config/darwin.c (darwin_emit_unwind_label): Rewrite to use + assemble_name rather than incorrectly emulating it. + * doc/extend.texi (Deprecated Features): Mention that ? and friends are removed from G++. diff --git a/gcc/config/darwin.c b/gcc/config/darwin.c index d251474..66d1ab0 100644 --- a/gcc/config/darwin.c +++ b/gcc/config/darwin.c @@ -1465,12 +1465,6 @@ darwin_handle_weak_import_attribute (tree *node, tree name, return NULL_TREE; } -static void -no_dead_strip (FILE *file, const char *lab) -{ - fprintf (file, ".no_dead_strip %s\n", lab); -} - /* Emit a label for an FDE, making it global and/or weak if appropriate. The third parameter is nonzero if this is for exception handling. The fourth parameter is nonzero if this is just a placeholder for an @@ -1479,46 +1473,44 @@ no_dead_strip (FILE *file, const char *lab) void darwin_emit_unwind_label (FILE *file, tree decl, int for_eh, int empty) { - const char *base; char *lab; - bool need_quotes; - - if (DECL_ASSEMBLER_NAME_SET_P (decl)) - base = IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)); - else - base = IDENTIFIER_POINTER (DECL_NAME (decl)); - - base = targetm.strip_name_encoding (base); - need_quotes = name_needs_quotes (base); if (! for_eh) return; - lab = concat (need_quotes ? "\"" : "", user_label_prefix, base, ".eh", - need_quotes ? "\"" : "", NULL); + lab = concat (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), ".eh", NULL); if (TREE_PUBLIC (decl)) - fprintf (file, "\t%s %s\n", - (DECL_VISIBILITY (decl) != VISIBILITY_HIDDEN - ? ".globl" - : ".private_extern"), - lab); + { + targetm.asm_out.globalize_label (file, lab); + if (DECL_VISIBILITY (decl) == VISIBILITY_HIDDEN) + { + fputs ("\t.private_extern ", file); + assemble_name (file, lab); + fputc ('\n', file); + } + } if (DECL_WEAK (decl)) - fprintf (file, "\t.weak_definition %s\n", lab); + { + fputs ("\t.weak_definition ", file); + assemble_name (file, lab); + fputc ('\n', file); + } + assemble_name (file, lab); if (empty) { - fprintf (file, "%s = 0\n", lab); + fputs (" = 0\n", file); /* Mark the absolute .eh and .eh1 style labels as needed to ensure that we don't dead code strip them and keep such labels from another instantiation point until we can fix this properly with group comdat support. */ - no_dead_strip (file, lab); + darwin_mark_decl_preserved (lab); } else - fprintf (file, "%s:\n", lab); + fputs (":\n", file); free (lab); } diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index d17226e..8a398e4 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -2223,6 +2223,7 @@ output_call_frame_info (int for_eh) specialization doesn't. */ if (TARGET_USES_WEAK_UNWIND_INFO && ! flag_asynchronous_unwind_tables + && flag_exceptions && for_eh) for (i = 0; i < fde_table_in_use; i++) if ((fde_table[i].nothrow || fde_table[i].all_throwers_are_sibcalls) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ff8f67d..a764dfe 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2007-10-09 Geoffrey Keating + + * gcc.dg/unwind-1.c: New. + 2007-10-09 Thomas Koenig PR libfortran/33683 diff --git a/gcc/testsuite/gcc.dg/unwind-1.c b/gcc/testsuite/gcc.dg/unwind-1.c new file mode 100644 index 0000000..a24af92 --- /dev/null +++ b/gcc/testsuite/gcc.dg/unwind-1.c @@ -0,0 +1,7 @@ +/* { dg-do assemble } */ +/* { dg-options "-fleading-underscore -funwind-tables" } */ + +void func(void) __asm("_func"); +void _func(int x) {} +void func(void) {} + -- cgit v1.1