From 76b7f60ffdb26c56d2c71bbeddf7da601de0e50e Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Fri, 10 Jan 2025 15:07:41 +0100 Subject: c: Fix up expr location for __builtin_stdc_rotate_* [PR118376] Seems I forgot to set_c_expr_source_range for the __builtin_stdc_rotate_* case (the other __builtin_stdc_* cases already have it), which means the locations in expr are uninitialized, sometimes causing ICEs in linemap code, at other times just valgrind errors about uninitialized var uses. 2025-01-10 Jakub Jelinek PR c/118376 * c-parser.cc (c_parser_postfix_expression): Call set_c_expr_source_range before break in the __builtin_stdc_rotate_* case. * gcc.dg/pr118376.c: New test. --- gcc/c/c-parser.cc | 1 + gcc/testsuite/gcc.dg/pr118376.c | 11 +++++++++++ 2 files changed, 12 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr118376.c (limited to 'gcc') diff --git a/gcc/c/c-parser.cc b/gcc/c/c-parser.cc index c46aac5..d2f4591 100644 --- a/gcc/c/c-parser.cc +++ b/gcc/c/c-parser.cc @@ -12906,6 +12906,7 @@ c_parser_postfix_expression (c_parser *parser) expr.value = build2_loc (loc, COMPOUND_EXPR, TREE_TYPE (expr.value), instrument_expr, expr.value); + set_c_expr_source_range (&expr, loc, close_paren_loc); break; } tree barg1 = arg; diff --git a/gcc/testsuite/gcc.dg/pr118376.c b/gcc/testsuite/gcc.dg/pr118376.c new file mode 100644 index 0000000..16b2f54 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr118376.c @@ -0,0 +1,11 @@ +/* PR c/118376 */ +/* { dg-do compile } */ +/* { dg-options "-Wsign-conversion" } */ + +unsigned x; + +void +foo () +{ + __builtin_memset (&x, (long long) __builtin_stdc_rotate_right (x, 0), 1); +} /* { dg-warning "conversion to 'int' from 'long long int' may change the sign of the result" "" { target *-*-* } .-1 } */ -- cgit v1.1