From f340142b839ca1ed576013b4dba3d34245bac7d0 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Tue, 5 Nov 2019 11:00:24 +0000 Subject: re PR tree-optimization/92324 (ICE in expand_direct_optab_fn, at internal-fn.c:2890) 2019-11-05 Richard Biener PR tree-optimization/92324 * tree-vect-loop.c (check_reduction_path): For MIN/MAX require all signed or unsigned operations. * gcc.dg/vect/pr92324-3.c: New testcase. From-SVN: r277822 --- gcc/tree-vect-loop.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'gcc/tree-vect-loop.c') diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 4064e9c..3448b55 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -2740,6 +2740,7 @@ pop: /* Check whether the reduction path detected is valid. */ bool fail = path.length () == 0; bool neg = false; + int sign = -1; *code = ERROR_MARK; for (unsigned i = 1; i < path.length (); ++i) { @@ -2783,12 +2784,22 @@ pop: TREE_TYPE (gimple_assign_rhs1 (use_stmt)))) ; else if (*code == ERROR_MARK) - *code = use_code; + { + *code = use_code; + sign = TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt))); + } else if (use_code != *code) { fail = true; break; } + else if ((use_code == MIN_EXPR + || use_code == MAX_EXPR) + && sign != TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt)))) + { + fail = true; + break; + } } return ! fail && ! neg && *code != ERROR_MARK; } -- cgit v1.1