From 46a5df00ab59a9bb816f5865efb9196e31bc18c6 Mon Sep 17 00:00:00 2001 From: Philip Herron Date: Sat, 29 Jul 2023 17:33:47 +0100 Subject: gccrs: fix ICE when we have unimplemented/invalid trait items When the resulting trait item is in an error state this means the underlying fields will be null. Fixes #2478 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-item.cc: add is_error check gcc/testsuite/ChangeLog: * rust/compile/non_member_const.rs: add missing error message * rust/compile/issue-2478.rs: New test. Signed-off-by: Philip Herron --- gcc/rust/typecheck/rust-hir-type-check-item.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'gcc/rust') diff --git a/gcc/rust/typecheck/rust-hir-type-check-item.cc b/gcc/rust/typecheck/rust-hir-type-check-item.cc index 98c5c1a..b329ac1 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-item.cc +++ b/gcc/rust/typecheck/rust-hir-type-check-item.cc @@ -615,7 +615,8 @@ TypeCheckItem::validate_trait_impl_block ( impl_item.get (), self, specified_bound, substitutions); - trait_item_refs.push_back (trait_item_ref.get_raw_item ()); + if (!trait_item_ref.is_error ()) + trait_item_refs.push_back (trait_item_ref.get_raw_item ()); } } -- cgit v1.1