From f4f546c9881c47923c7d37e8cf7a9bc35f37489c Mon Sep 17 00:00:00 2001 From: badumbatish Date: Thu, 29 Aug 2024 10:07:19 -0700 Subject: gccrs: Rehaul, Apply code review from Arthur gcc/rust/ChangeLog: * backend/rust-compile-asm.cc (CompileAsm::visit): Change API, public/private, comments, formatting from code review (CompileAsm::asm_build_expr): Likewise. (CompileAsm::tree_codegen_asm): Likewise. * backend/rust-compile-asm.h (class CompileAsm): Likewise. * backend/rust-compile-expr.cc (CompileExpr::visit): Likewise. * checks/errors/privacy/rust-privacy-reporter.cc (PrivacyReporter::visit): Likewise. * expand/rust-macro-builtins-asm.cc (strip_double_quotes): Likewise. (parse_options): Likewise. (parse_asm_arg): Likewise. (expand_inline_asm_strings): Likewise. (parse_asm): Likewise. * expand/rust-macro-builtins-asm.h (strip_double_quotes): Likewise. (expand_inline_asm_strings): Likewise. (expand_inline_asm_string): Likewise. * hir/tree/rust-hir-expr.h: Likewise. gcc/testsuite/ChangeLog: * rust/compile/inline_asm_typecheck.rs: Change comments --- gcc/rust/hir/tree/rust-hir-expr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gcc/rust/hir/tree/rust-hir-expr.h') diff --git a/gcc/rust/hir/tree/rust-hir-expr.h b/gcc/rust/hir/tree/rust-hir-expr.h index da5dd12..8a2d82f 100644 --- a/gcc/rust/hir/tree/rust-hir-expr.h +++ b/gcc/rust/hir/tree/rust-hir-expr.h @@ -4154,8 +4154,8 @@ public: bool is_inline_asm () { - // TODO: Check back later to determine how an InlineAsm is inline. - return true; + // INFO: An inline asm is asm!, which is the opposite of a global_asm() + return !this->is_global_asm; } InlineAsm (location_t locus, bool is_global_asm, std::vector template_, -- cgit v1.1