From dffb1adabd3853a8d1100e53d5fa351f8b5f180c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= Date: Sat, 15 Jan 2022 22:43:08 +0100 Subject: HIR Visitor refactoring MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change split the single HIR visitor in smaller abstract ones: - Stmt - VisItem - Pattern - ExternalItem - Impl - Type - Expression Instead of providing a Base class with empty visit() methods, they are kept abstract to avoid the case where a missing visit() is silently ignored: implementors must explicitely override all visit. There is also a FullVisitor that covers all HIR nodes and also provides a Base class with empty behavior. fixes #825 Signed-off-by: Marc Poulhiès --- gcc/rust/backend/rust-compile-resolve-path.h | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) (limited to 'gcc/rust/backend/rust-compile-resolve-path.h') diff --git a/gcc/rust/backend/rust-compile-resolve-path.h b/gcc/rust/backend/rust-compile-resolve-path.h index 9c9d7c5..37dec0b 100644 --- a/gcc/rust/backend/rust-compile-resolve-path.h +++ b/gcc/rust/backend/rust-compile-resolve-path.h @@ -25,10 +25,8 @@ namespace Rust { namespace Compile { -class ResolvePathRef : public HIRCompileBase +class ResolvePathRef : public HIRCompileBase, public HIR::HIRPatternVisitor { - using Rust::Compile::HIRCompileBase::visit; - public: static tree Compile (HIR::QualifiedPathInExpression &expr, Context *ctx) { @@ -45,10 +43,20 @@ public: } void visit (HIR::PathInExpression &expr) override; - void visit (HIR::QualifiedPathInExpression &expr) override; -private: + // Empty visit for unused Pattern HIR nodes. + void visit (HIR::GroupedPattern &) override {} + void visit (HIR::IdentifierPattern &) override {} + void visit (HIR::LiteralPattern &) override {} + void visit (HIR::RangePattern &) override {} + void visit (HIR::ReferencePattern &) override {} + void visit (HIR::SlicePattern &) override {} + void visit (HIR::StructPattern &) override {} + void visit (HIR::TuplePattern &) override {} + void visit (HIR::TupleStructPattern &) override {} + void visit (HIR::WildcardPattern &) override {} + ResolvePathRef (Context *ctx) : HIRCompileBase (ctx), resolved (error_mark_node) {} -- cgit v1.1