From 22149e37f7537843947003b4c7df76b69dd287ac Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Thu, 1 Feb 2018 01:38:52 +0000 Subject: compiler: check for nil receiver in value method We already dereference the pointer to copy the value, but if the method does not use the value then the pointer dereference may be optimized away. Do an explicit nil check so that we get the panic that is required. Fixes golang/go#19806 Reviewed-on: https://go-review.googlesource.com/91275 * go.go-torture/execute/printnil.go: New test. From-SVN: r257280 --- gcc/go/gofrontend/MERGE | 2 +- gcc/go/gofrontend/gogo.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'gcc/go') diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index c115b2e..7dc0063 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -65eaa9003db4effc9c5ffe9c955e9534ba5d7d15 +71758f9ca1804743afe178f0e2fca489e0217474 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/gcc/go/gofrontend/gogo.cc b/gcc/go/gofrontend/gogo.cc index 3f784dd..04edb08 100644 --- a/gcc/go/gofrontend/gogo.cc +++ b/gcc/go/gofrontend/gogo.cc @@ -5610,7 +5610,7 @@ Function::build(Gogo* gogo, Named_object* named_function) Expression::make_var_reference(parm_no, loc); parm_ref = Expression::make_dereference(parm_ref, - Expression::NIL_CHECK_DEFAULT, + Expression::NIL_CHECK_NEEDED, loc); if ((*p)->var_value()->is_in_heap()) parm_ref = Expression::make_heap_expression(parm_ref, loc); -- cgit v1.1