From 751b37047b2ad3a358d41ac792487b42430e9901 Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Tue, 25 Feb 2025 14:17:16 +0100 Subject: Fortran: Remove SAVE_EXPR on lhs in assign [PR108233] With vectorial shaped datatypes like e.g. complex numbers, fold_convert inserts a SAVE_EXPR. Using that on the lhs in an assignment prevented the update of the variable, when in a coarray. PR fortran/108233 gcc/fortran/ChangeLog: * trans-expr.cc (gfc_trans_assignment_1): Remove SAVE_EXPR on lhs. gcc/testsuite/ChangeLog: * gfortran.dg/coarray/complex_1.f90: New test. --- gcc/fortran/trans-expr.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'gcc/fortran/trans-expr.cc') diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc index 8a3e737..ab55940 100644 --- a/gcc/fortran/trans-expr.cc +++ b/gcc/fortran/trans-expr.cc @@ -13017,11 +13017,14 @@ gfc_trans_assignment_1 (gfc_expr * expr1, gfc_expr * expr2, bool init_flag, else { gfc_conv_expr (&lse, expr1); - if (gfc_option.rtcheck & GFC_RTCHECK_MEM - && !init_flag - && gfc_expr_attr (expr1).allocatable - && expr1->rank - && !expr2->rank) + /* For some expression (e.g. complex numbers) fold_convert uses a + SAVE_EXPR, which is hazardous on the lhs, because the value is + not updated when assigned to. */ + if (TREE_CODE (lse.expr) == SAVE_EXPR) + lse.expr = TREE_OPERAND (lse.expr, 0); + + if (gfc_option.rtcheck & GFC_RTCHECK_MEM && !init_flag + && gfc_expr_attr (expr1).allocatable && expr1->rank && !expr2->rank) { tree cond; const char* msg; -- cgit v1.1