From ac219d524ace47eea5bf5404b267e22950f44030 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Tue, 16 Jan 2024 15:49:46 -0500 Subject: c++: fix ICE with xobj in destructor [PR113340] Here we crash in maybe_retrofit_in_chrg on an invalid dtor with explicit this. Such member functions do not get converted to METHOD_TYPE. If a dtor gets parameters, we reset arg_types to void_list_node in grokdeclarator. This results in m_r_in_c receiving: void (void) and crashing on parms = DECL_CHAIN (DECL_ARGUMENTS (fn)); This patch avoids the ICE by resetting is_xobj_member_function after emitting the error. Then m_r_in_c gets void S:: (struct S *) which does not cause a crash. PR c++/113340 gcc/cp/ChangeLog: * decl.cc (grokdeclarator) : Clear is_xobj_member_function in case of an error. gcc/testsuite/ChangeLog: * g++.dg/cpp23/explicit-obj-diagnostics9.C: New test. --- gcc/cp/decl.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'gcc/cp') diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc index b10a72a..2e57029 100644 --- a/gcc/cp/decl.cc +++ b/gcc/cp/decl.cc @@ -13743,6 +13743,7 @@ grokdeclarator (const cp_declarator *declarator, "destructors may not have parameters"); arg_types = void_list_node; parms = NULL_TREE; + is_xobj_member_function = false; } type = build_function_type (type, arg_types); -- cgit v1.1