From d49b251f6d08fda3db606ac0e50cd28daac9eb33 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Fri, 10 May 2019 14:53:30 +0000 Subject: PR c++/78010 - bogus -Wsuggest-override warning on final function. * class.c (check_for_override): Don't warn for final functions. * g++.dg/warn/Wsuggest-override-2.C: New test. From-SVN: r271065 --- gcc/cp/class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'gcc/cp/class.c') diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 712169c..a47777c 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @@ -2780,7 +2780,9 @@ check_for_override (tree decl, tree ctype) { DECL_VINDEX (decl) = decl; overrides_found = true; - if (warn_override && !DECL_OVERRIDE_P (decl) + if (warn_override + && !DECL_OVERRIDE_P (decl) + && !DECL_FINAL_P (decl) && !DECL_DESTRUCTOR_P (decl)) warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wsuggest_override, "%qD can be marked override", decl); -- cgit v1.1