From 56778b69ce558bb7e3ab7c561ee4ee48ac20263b Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Fri, 19 Jan 2024 09:31:42 +0100 Subject: expansion: Fix ICEs with BLKmode VIEW_CONVERT_EXPR around non-BLKmode VAR_DECLs On aarch64 the backend decides to use non-BLKmode for some arrays like unsigned long[4] - OImode in that case, but the corresponding BITINT_TYPEs have BLKmode (like structures containing that many limb elements). This later causes ICEs durring expansion when expanding VIEW_CONVERT_EXPR from non-BLKmode VAR_DECL to BLKmode BITINT_TYPE. The following fix contains two parts, the discover_nonconstant_array_refs_r is make sure we force such variables into memory and the expand_expr_real_1 change makes sure we don't try to extract a bitfield or something similar which doesn't really work for BLKmode - as op0 is a MEM, all we need is the op0 = adjust_address (op0, mode, 0); at the end to change the MEM's mode to BLKmode. 2024-01-19 Jakub Jelinek Richard Biener * cfgexpand.cc (discover_nonconstant_array_refs_r): Force non-BLKmode VAR_DECLs referenced in BLKmode VIEW_CONVERT_EXPRs into memory. * expr.cc (expand_expr_real_1) : Do nothing but adjust_address also for BLKmode mode and MEM op0. --- gcc/cfgexpand.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'gcc/cfgexpand.cc') diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc index 9ce0118..767982a 100644 --- a/gcc/cfgexpand.cc +++ b/gcc/cfgexpand.cc @@ -6380,11 +6380,15 @@ discover_nonconstant_array_refs_r (tree * tp, int *walk_subtrees, /* References of size POLY_INT_CST to a fixed-size object must go through memory. It's more efficient to force that here than to create temporary slots on the fly. - RTL expansion expectes TARGET_MEM_REF to always address actual memory. */ + RTL expansion expectes TARGET_MEM_REF to always address actual memory. + Also, force to stack non-BLKmode vars accessed through VIEW_CONVERT_EXPR + to BLKmode type. */ else if (TREE_CODE (t) == TARGET_MEM_REF || (TREE_CODE (t) == MEM_REF && TYPE_SIZE (TREE_TYPE (t)) - && POLY_INT_CST_P (TYPE_SIZE (TREE_TYPE (t))))) + && POLY_INT_CST_P (TYPE_SIZE (TREE_TYPE (t)))) + || (TREE_CODE (t) == VIEW_CONVERT_EXPR + && TYPE_MODE (TREE_TYPE (t)) == BLKmode)) { tree base = get_base_address (t); if (base -- cgit v1.1