From 1636e85270d918a84d57bb521c22c42abf42a47c Mon Sep 17 00:00:00 2001 From: Martin Uecker Date: Sat, 1 Mar 2025 21:32:21 +0100 Subject: c: Fix bug in typedef redefinitions of tagged types [PR118765] When we redefine a tagged type we incorrectly update TYPE_STUB_DECL of the previously defined type instead of the new one. Because TYPE_STUB_DECL is used when determining whether two such types are the same, this can cause valid typedef redefinitions to be rejected later. This is only a partial fix for PR118765. PR c/118765 gcc/c/ChangeLog: * c-decl.cc (finish_struct,finish_enum): Swap direction when copying TYPE_STRUB_DECL in redefinitions. gcc/testsuite/ChangeLog: * gcc.dg/pr118765.c: New test. --- gcc/c/c-decl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gcc/c') diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc index 0dcbae9..1ae5208 100644 --- a/gcc/c/c-decl.cc +++ b/gcc/c/c-decl.cc @@ -9846,7 +9846,7 @@ finish_struct (location_t loc, tree t, tree fieldlist, tree attributes, && TREE_CODE (vistype) == TREE_CODE (t) && !C_TYPE_BEING_DEFINED (vistype)) { - TYPE_STUB_DECL (vistype) = TYPE_STUB_DECL (t); + TYPE_STUB_DECL (t) = TYPE_STUB_DECL (vistype); if (c_type_variably_modified_p (t)) { error ("redefinition of struct or union %qT with variably " @@ -10321,7 +10321,7 @@ finish_enum (tree enumtype, tree values, tree attributes) && TREE_CODE (vistype) == TREE_CODE (enumtype) && !C_TYPE_BEING_DEFINED (vistype)) { - TYPE_STUB_DECL (vistype) = TYPE_STUB_DECL (enumtype); + TYPE_STUB_DECL (enumtype) = TYPE_STUB_DECL (vistype); if (!comptypes_same_p (enumtype, vistype)) error("conflicting redefinition of enum %qT", enumtype); } -- cgit v1.1