From 5db9ce171019f8915885cebd5cc5f4101bb926e6 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Tue, 29 Mar 2022 14:36:55 -0400 Subject: c-family: ICE with -Wconversion and A ?: B [PR101030] This patch fixes a crash in conversion_warning on a null expression. It is null because the testcase uses the GNU A ?: B extension. We could also use op0 instead of op1 in this case, but it doesn't seem to be necessary. PR c++/101030 gcc/c-family/ChangeLog: * c-warn.cc (conversion_warning) : Don't call conversion_warning when OP1 is null. gcc/testsuite/ChangeLog: * g++.dg/ext/cond5.C: New test. --- gcc/c-family/c-warn.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gcc/c-family/c-warn.cc') diff --git a/gcc/c-family/c-warn.cc b/gcc/c-family/c-warn.cc index 9025fc1..f24ac5d 100644 --- a/gcc/c-family/c-warn.cc +++ b/gcc/c-family/c-warn.cc @@ -1300,7 +1300,7 @@ conversion_warning (location_t loc, tree type, tree expr, tree result) tree op1 = TREE_OPERAND (expr, 1); tree op2 = TREE_OPERAND (expr, 2); - return (conversion_warning (loc, type, op1, result) + return ((op1 && conversion_warning (loc, type, op1, result)) || conversion_warning (loc, type, op2, result)); } -- cgit v1.1