From 2d8b144a2a61b007f59286731275773f6e167be1 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 17 Nov 2020 09:37:25 +0100 Subject: c: Reject _Atomic type * as last argument to __builtin_*_overflow [PR90628] During the __builtin_clear_padding implementation, I've noticed we don't diagnose _Atomic whatever * as last argument to __builtin_*_overflow. As the storing by that builtin isn't atomic in any way, I think we should reject it. 2020-11-17 Jakub Jelinek PR c/90628 * c-common.c (check_builtin_function_arguments) : Diagnose when last argument is pointer to _Atomic. For the TYPE_READONLY case, adjust message to be usable for more builtins and argument positions. * gcc.dg/builtin-arith-overflow-4.c: New test. --- gcc/c-family/c-common.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'gcc/c-family/c-common.c') diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index ab7f642..729bd85 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -6133,11 +6133,18 @@ check_builtin_function_arguments (location_t loc, vec arg_loc, } else if (TYPE_READONLY (TREE_TYPE (TREE_TYPE (args[2])))) { - error_at (ARG_LOCATION (2), "argument 3 in call to function %qE " - "has pointer to % type (%qT)", fndecl, + error_at (ARG_LOCATION (2), "argument %u in call to function %qE " + "has pointer to %qs type (%qT)", 3, fndecl, "const", TREE_TYPE (args[2])); return false; } + else if (TYPE_ATOMIC (TREE_TYPE (TREE_TYPE (args[2])))) + { + error_at (ARG_LOCATION (2), "argument %u in call to function %qE " + "has pointer to %qs type (%qT)", 3, fndecl, + "_Atomic", TREE_TYPE (args[2])); + return false; + } return true; } return false; -- cgit v1.1