From 0ba70d1b5ae8df6406a880b2d23e4710b393e8c9 Mon Sep 17 00:00:00 2001 From: David Malcolm Date: Wed, 26 Feb 2020 09:43:57 -0500 Subject: analyzer: fix ICE on unreachable calls [PR 93947] PR analyzer/93947 reports an ICE at -O1 when attempting to analyze a call that has been optimized away as unreachable. The root cause is a NULL dereference due to the fndecl having a NULL cgraph_node: the cgraph_node was created by pass_build_cgraph_edges::execute, but was later removed by symbol_table::remove_unreachable_nodes before the analyzer pass. This patch fixes it by checking for NULL before handling the cgraph_node. The reproducer demonstrates a weakness in the analyzer's constraint handling, where region_model::apply_constraints_for_gswitch fails to spot when the cases fully cover the data type, and thus make the default impossible. For now this is xfail-ed in the testcase. gcc/analyzer/ChangeLog: PR analyzer/93947 * region-model.cc (region_model::get_fndecl_for_call): Gracefully fail for fn_decls that don't have a cgraph_node. gcc/testsuite/ChangeLog: PR analyzer/93947 * gcc.dg/analyzer/torture/pr93947.c: New test. --- gcc/analyzer/ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'gcc/analyzer/ChangeLog') diff --git a/gcc/analyzer/ChangeLog b/gcc/analyzer/ChangeLog index 982cc3c..92377be 100644 --- a/gcc/analyzer/ChangeLog +++ b/gcc/analyzer/ChangeLog @@ -1,5 +1,11 @@ 2020-02-26 David Malcolm + PR analyzer/93947 + * region-model.cc (region_model::get_fndecl_for_call): Gracefully + fail for fn_decls that don't have a cgraph_node. + +2020-02-26 David Malcolm + * bar-chart.cc: New file. * bar-chart.h: New file. * engine.cc: Include "analyzer/bar-chart.h". -- cgit v1.1