From e5428086c2c8daf69e5916dd5016d1e7b85d3f0d Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Wed, 24 Aug 2022 23:47:43 +0100 Subject: Revert "libstdc++: Optimize operator+(string/char*, char*/string) equally" This reverts commit 0b7c9254998b3fb2c39f6b86b5b196f415530205. --- libstdc++-v3/include/bits/basic_string.h | 9 +++++++-- libstdc++-v3/include/bits/basic_string.tcc | 21 --------------------- 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h index fa67389..b04fba9 100644 --- a/libstdc++-v3/include/bits/basic_string.h +++ b/libstdc++-v3/include/bits/basic_string.h @@ -3521,9 +3521,14 @@ _GLIBCXX_END_NAMESPACE_CXX11 */ template _GLIBCXX20_CONSTEXPR - basic_string<_CharT, _Traits, _Alloc> + inline basic_string<_CharT, _Traits, _Alloc> operator+(const basic_string<_CharT, _Traits, _Alloc>& __lhs, - const _CharT* __rhs); + const _CharT* __rhs) + { + basic_string<_CharT, _Traits, _Alloc> __str(__lhs); + __str.append(__rhs); + return __str; + } /** * @brief Concatenate string and character. diff --git a/libstdc++-v3/include/bits/basic_string.tcc b/libstdc++-v3/include/bits/basic_string.tcc index 95ba8e5..4563c61 100644 --- a/libstdc++-v3/include/bits/basic_string.tcc +++ b/libstdc++-v3/include/bits/basic_string.tcc @@ -641,27 +641,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } template - _GLIBCXX20_CONSTEXPR - basic_string<_CharT, _Traits, _Alloc> - operator+(const basic_string<_CharT, _Traits, _Alloc>& __lhs, - const _CharT* __rhs) - { - __glibcxx_requires_string(__rhs); - typedef basic_string<_CharT, _Traits, _Alloc> __string_type; - typedef typename __string_type::size_type __size_type; - typedef typename __gnu_cxx::__alloc_traits<_Alloc>::template - rebind<_CharT>::other _Char_alloc_type; - typedef __gnu_cxx::__alloc_traits<_Char_alloc_type> _Alloc_traits; - const __size_type __len = _Traits::length(__rhs); - __string_type __str(_Alloc_traits::_S_select_on_copy( - __lhs.get_allocator())); - __str.reserve(__len + __lhs.size()); - __str.append(__lhs); - __str.append(__rhs, __len); - return __str; - } - - template _GLIBCXX_STRING_CONSTEXPR typename basic_string<_CharT, _Traits, _Alloc>::size_type basic_string<_CharT, _Traits, _Alloc>:: -- cgit v1.1