From 164b41ebf3e25bdb0b30e230591c463ce56df9d4 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Wed, 12 Oct 2016 12:20:25 +0100 Subject: Do not copy std:call_once arguments (LWG 2442) * doc/xml/manual/intro.xml: Document LWG 2442 status. * include/std/mutex [_GLIBCXX_HAVE_TLS] (__once_call_impl): Remove. [_GLIBCXX_HAVE_TLS] (_Once_call): Declare primary template and define partial specialization to unpack args and forward to std::invoke. (call_once) [_GLIBCXX_HAVE_TLS]: Use forward_as_tuple and _Once_call instead of __bind_simple and __once_call_impl. (call_once) [!_GLIBCXX_HAVE_TLS]: Use __invoke instead of __bind_simple. * testsuite/30_threads/call_once/dr2442.cc: New test. From-SVN: r241031 --- libstdc++-v3/ChangeLog | 12 ++++++ libstdc++-v3/doc/xml/manual/intro.xml | 7 ++++ libstdc++-v3/include/std/mutex | 35 +++++++++++------ .../testsuite/30_threads/call_once/dr2442.cc | 45 ++++++++++++++++++++++ 4 files changed, 87 insertions(+), 12 deletions(-) create mode 100644 libstdc++-v3/testsuite/30_threads/call_once/dr2442.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index cf51dd7..6dfe263 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,15 @@ +2016-10-12 Jonathan Wakely + + * doc/xml/manual/intro.xml: Document LWG 2442 status. + * include/std/mutex [_GLIBCXX_HAVE_TLS] (__once_call_impl): Remove. + [_GLIBCXX_HAVE_TLS] (_Once_call): Declare primary template and define + partial specialization to unpack args and forward to std::invoke. + (call_once) [_GLIBCXX_HAVE_TLS]: Use forward_as_tuple and _Once_call + instead of __bind_simple and __once_call_impl. + (call_once) [!_GLIBCXX_HAVE_TLS]: Use __invoke instead of + __bind_simple. + * testsuite/30_threads/call_once/dr2442.cc: New test. + 2016-10-11 Jonathan Wakely * include/bits/stl_list.h (assign(initializer_list)): Call diff --git a/libstdc++-v3/doc/xml/manual/intro.xml b/libstdc++-v3/doc/xml/manual/intro.xml index 22b792a..528b192 100644 --- a/libstdc++-v3/doc/xml/manual/intro.xml +++ b/libstdc++-v3/doc/xml/manual/intro.xml @@ -1043,6 +1043,13 @@ requirements of the license of GCC. Define the typedefs. + 2442: + call_once() shouldn't DECAY_COPY() + + Remove indirection through call wrapper that made copies + of arguments and forward arguments straight to std::invoke. + + 2454: Add raw_storage_iterator::base() member diff --git a/libstdc++-v3/include/std/mutex b/libstdc++-v3/include/std/mutex index 7a7bd2e..4c6f036 100644 --- a/libstdc++-v3/include/std/mutex +++ b/libstdc++-v3/include/std/mutex @@ -580,12 +580,20 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION extern __thread void* __once_callable; extern __thread void (*__once_call)(); - template - inline void - __once_call_impl() + template::value>::__type> + struct _Once_call; + + template + struct _Once_call<_Tuple, _Index_tuple<_Ind...>> { - (*(_Callable*)__once_callable)(); - } + static void + _S_call() + { + auto& __f_args = *static_cast<_Tuple*>(__once_callable); + std::__invoke(std::get<_Ind>(std::move(__f_args))...); + } + }; #else extern function __once_functor; @@ -603,16 +611,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION void call_once(once_flag& __once, _Callable&& __f, _Args&&... __args) { + // _GLIBCXX_RESOLVE_LIB_DEFECTS + // 2442. call_once() shouldn't DECAY_COPY() #ifdef _GLIBCXX_HAVE_TLS - auto __bound_functor = std::__bind_simple(std::forward<_Callable>(__f), - std::forward<_Args>(__args)...); - __once_callable = std::__addressof(__bound_functor); - __once_call = &__once_call_impl; + auto __f_args = std::forward_as_tuple( + std::forward<_Callable>(__f), std::forward<_Args>(__args)...); + __once_callable = std::__addressof(__f_args); + __once_call = _Once_call::_S_call; #else unique_lock __functor_lock(__get_once_mutex()); - auto __callable = std::__bind_simple(std::forward<_Callable>(__f), - std::forward<_Args>(__args)...); - __once_functor = [&]() { __callable(); }; + __once_functor = [&] { + std::__invoke(std::forward<_Callable>(__f), + std::forward<_Args>(__args)...); + }; __set_once_functor_lock_ptr(&__functor_lock); #endif diff --git a/libstdc++-v3/testsuite/30_threads/call_once/dr2442.cc b/libstdc++-v3/testsuite/30_threads/call_once/dr2442.cc new file mode 100644 index 0000000..5b66687 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/call_once/dr2442.cc @@ -0,0 +1,45 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-rtems* *-*-darwin* powerpc-ibm-aix* } } +// { dg-options "-pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* powerpc-ibm-aix* } } +// { dg-require-effective-target c++11 } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2016 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +#include +#include + +void f(int& a, int&& b) { a = 1; b = 2; } + +void +test01() +{ + // LWG 2442. call_once() shouldn't DECAY_COPY() + std::once_flag once; + int i = 0; + int j = 0; + call_once(once, f, i, std::move(j)); + VERIFY( i == 1 ); + VERIFY( j == 2 ); +} + +int +main() +{ + test01(); +} -- cgit v1.1